Repository navigation
Bump ntnda-qt-viewer so detector x-axis labels run 0 -> N - #114
Merged
Merged
Conversation
The pinned 6763cde drew the frame source-oriented but labelled the x axis from a rotate180-then-invert-x copy, so the Kinetix live view read 3200 -> 0 left to right (Phoebus: 0 -> 3200). ntnda-qt-viewer 46dcea3 (2026-10-26) dropped the orientation presets; at 778e714 the picture is unchanged and the labels match source pixels. Lock change is only ntnda-qt-viewer (dev and gui). Assisted-by: copilot:claude-opus-5-5
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused dependency update and regression test address the reported reversal with no identified blockers, though live Kinetix validation remains outstanding.
No open issues 🎉
What changed in this PR
Updates the detector viewer dependency to correct reversed x-axis labels in the Kinetix live view.
Changes:
- Advances
ntnda-qt-viewerfrom6763cdeto778e714in the dev and gui environments, without changing other packages. - Adds an offscreen regression test checking increasing x-axis labels and source-column orientation.
| File | Description |
|---|---|
tests/gui/test_detector_viewer_axes.py |
Adds column-ramp regression coverage for viewer x-axis orientation. |
pixi.lock |
Updates both environment references and package metadata to the corrected viewer revision. |
Review effort: Balanced
Anthony Sligar (sligara7)
removed the request for review
from Jakub Wlodek (jwlodek)
October 27, 2026 15:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Kinetix live view's x axis reads 3200 → 0 left to right (Phoebus: 0 → 3200). The pinned ntnda-qt-viewer (6763cde) labels the axis from a rotate180-then-invert-x copy of the frame; the picture itself is drawn correctly. ntnda-qt-viewer 46dcea3 removed those orientation presets.
pixi.lock: ntnda-qt-viewer 6763cde → 778e714 (dev and gui only; no other package moves).tests/gui/test_detector_viewer_axes.py: pushes a column-ramp frame into the viewer offscreen and checks the x labels increase left to right over source columns 0 → N. Fails on 6763cde, passes on 778e714.Verified: offscreen widget test (no EPICS) plus the full suite in an env built from this lock (458 pass,
tyclean). Not yet checked on the HEX GUI against the live Kinetix.