Skip to content

fix(camera_viz): keep one CuPy variant after setup installs dependencies - #1546

Open
fvaloppi-nv wants to merge 1 commit into
mainfrom
codex/fix-camera-viz-cupy-main
Open

fvaloppi-nv wants to merge 1 commit into
mainfrom
codex/fix-camera-viz-cupy-main

Conversation

@fvaloppi-nv

@fvaloppi-nv fvaloppi-nv commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Description

On CUDA 13 hosts, installing isaaccapture[cloudxr] can bring cupy-cuda12x back after setup removes stale CuPy variants, leaving both variants installed and causing the CUDA check to fail.

Apply the same fix as #1424 to main: remove non-target CuPy variants after dependency installation and reinstall the target variant because the packages share the cupy/ directory. Cherry-picked from cc8d7e5 with original authorship preserved. #1424 targets release/1.7.x.

Related: NVBug 7047715

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Testing

  • SKIP=check-copyright-year pre-commit run --all-files — passed.
  • bash -n examples/camera_viz/scripts/_install_deps.sh — passed.
  • git diff origin/main --check — passed.
  • CUDA setup was not run; this change reproduces the original shell fix without installing GPU dependencies locally.

Checklist

  • I have read and understood the contribution guidelines.
  • I have run the linter and formatter with SKIP=check-copyright-year pre-commit run --all-files.
  • Documentation: no public interface change; the source comment explains the cleanup.
  • Tests: syntax and repository checks passed; no new tests for this direct cherry-pick.
  • I have signed off all my commits (git commit -s) per the DCO.

Summary by CodeRabbit

  • Bug Fixes
    • Dependency setup now removes non-matching CuPy variants and reinstalls the CuPy package that matches the selected CUDA major version. This helps keep the installed package aligned with the requested CUDA configuration and avoids leaving a conflicting CuPy variant in the environment after setup completes.

On a CUDA 13 host setup targets cupy-cuda13x, but isaaccapture[cloudxr]
depends on cupy-cuda12x, so the same install brings in both variants.
The existing stale-variant removal runs before that install and cannot
catch it. CuPy then warns about multiple CuPy packages and the CUDA
check fails ("Selected CUDA 13, but CuPy loaded NVRTC 12.8").

After the install, remove any non-target variant again and reinstall the
target, since the variants share the cupy/ directory.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Grecia Salazar Estrada <gsalazarestr@nvidia.com>
(cherry picked from commit cc8d7e5)
Signed-off-by: fvaloppi-nv <fvaloppi@nvidia.com>
@coderabbitai

coderabbitai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

After installing the requested packages, the script checks for installed CuPy 11x, 12x, and 13x variants. If a variant does not match the target, the script uninstalls it and reinstalls the target CuPy package.

Estimated code review effort: 2 (Simple) | ~8 minutes

Merge Risk: Minimal · up to d6647

This change fixes CuPy variant conflicts on CUDA 13 hosts during camera_viz setup by removing stale variants and reinstalling the matching one. No merge-blocking risk was found. The CUDA install path was not run end to end.

Architecture risk: Low · up to d6647

The change affects 1 system.

Changed systems: examples

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — examples (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in examples/camera_viz/scripts/_install_deps.sh: After package installation, the script checks the CuPy 11x, 12x, and 13x variants. For each installed variant other than the CUDA-major-matched target, it uninstalls that variant and reinstalls the target CuPy package.
Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the core change: after setup installs dependencies, the script keeps a single CuPy variant. The raw summary confirms the script removes non-target CuPy variants and reinstalls the CUDA…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Full details: Title check

Explanation

The title names the core change: after setup installs dependencies, the script keeps a single CuPy variant. The raw summary confirms the script removes non-target CuPy variants and reinstalls the CUDA-major-matched target package, and the objectives describe the same CUDA 12/13 conflict fix. The title is specific and matches the changeset. The title's "fix(camera_viz)" prefix is a conventional-commit style scope and does not affect the assessment.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between dc10c4f and d66475c.

Files selected for processing: 1

  • examples/camera_viz/scripts/_install_deps.sh

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

This branch was successfully deployed

1 active deployment
dev — d66475ca Deployed Nov 17, 2026 by fvaloppi-nv via publish-wheel #7055
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants