Tamil TN Cardinal Semiotic Class - #449
Conversation
b06d8e8 to
6b431c2
Compare
Signed-off-by: surendran-246 <surendrans@nvidia.com>
Signed-off-by: surendran-246 <surendrans@nvidia.com>
Signed-off-by: surendran-246 <surendrans@nvidia.com>
Signed-off-by: surendran-246 <surendrans@nvidia.com>
Signed-off-by: surendran-246 <surendrans@nvidia.com>
Signed-off-by: surendran-246 <surendrans@nvidia.com>
Signed-off-by: surendran-246 <surendrans@nvidia.com>
for more information, see https://pre-commit.ci Signed-off-by: surendran-246 <surendrans@nvidia.com>
Signed-off-by: surendran-246 <surendrans@nvidia.com>
231dd35 to
eaf2223
Compare
Signed-off-by: surendran-246 <surendrans@nvidia.com>
surendran-246
changed the title
Signed-off-by: surendran-246 <surendrans@nvidia.com>
Signed-off-by: surendran-246 <surendrans@nvidia.com>
Signed-off-by: surendran-246 <surendrans@nvidia.com>
Signed-off-by: surendran-246 <surendrans@nvidia.com>
for more information, see https://pre-commit.ci
Signed-off-by: surendran-246 <surendrans@nvidia.com>
|
This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days. |
Signed-off-by: surendran-246 <surendrans@nvidia.com>
0e62120 to
2907744
Compare
Signed-off-by: surendran-246 <surendrans@nvidia.com>
for more information, see https://pre-commit.ci
Signed-off-by: surendran-246 <surendrans@nvidia.com>
|
This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days. |
Signed-off-by: surendran-246 <surendrans@nvidia.com>
for more information, see https://pre-commit.ci
Signed-off-by: surendran-246 <surendrans@nvidia.com>
for more information, see https://pre-commit.ci
Signed-off-by: surendran-246 <surendrans@nvidia.com>
Signed-off-by: surendran-246 <surendrans@nvidia.com>
for more information, see https://pre-commit.ci
|
Hi @mgrafu, Thanks for the review. I've addressed all the review comments. On the teens_and_ties.tsv line count: from my side I can only see 68 lines (10–19 + X0/X1/X2 for each of the 8 tens digits, not 90 lines. Attaching the file link below for reference: Testing: Cardinal, word, and punctuation pytest cases passed |
Signed-off-by: surendran-246 <surendrans@nvidia.com>
Signed-off-by: surendran-246 <surendrans@nvidia.com>
for more information, see https://pre-commit.ci
| ௦௭௩~சுழியம் ஏழு மூன்று | ||
| 0001~சுழியம் சுழியம் சுழியம் ஒன்று | ||
| ௦௦௦~சுழியம் சுழியம் சுழியம் | ||
| 10000~பத்துஆயிரம் |
| 100000000000~பத்துஆயிரம் கோடி | ||
| 800~எட்டுநூறு | ||
| 850~எட்டுநூற்று ஐம்பது | ||
| 900~ஒன்பதுநூறு |
| 900~ஒன்பதுநூறு | ||
| 905~ஒன்பதுநூற்று ஐந்து | ||
| 987~ஒன்பதுநூற்று எண்பத்திஏழு | ||
| 25~இருபத்திஐந்து |
There was a problem hiding this comment.
why are all three spelled differently here? https://www.softschools.com/languages/tamil/tamil_numbers_1_100/
Signed-off-by: surendran-246 <surendrans@nvidia.com>
for more information, see https://pre-commit.ci
|
Hi @mgrafu, thanks for the review! I've addressed all the review comments — updated the cardinal.py verbalizer docstring to reflect the actual tagger output, and reformatted test_cases_punctuation.txt and test_cases_word.txt to follow the English test case style. I also double-checked the spellings you flagged in test_cases_cardinal.txt, and they're correct as is. Testing: |
| (3–7) மற்றும் (10–15)~(மூன்று – ஏழு) மற்றும் (பத்து – பதினைந்து) | ||
| 11;12;13~பதினொன்று;பன்னிரண்டு;பதிமூன்று | ||
| கோட்: "3"~கோட்: "மூன்று" | ||
| (20)வணக்கம்~(20)வணக்கம் |
There was a problem hiding this comment.
why is the number not normalized here?
3 participants
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Before your PR is "Ready for review"
Pre checks:
git commit -sto sign.pytestor (if your machine does not have GPU)pytest --cpufrom the root folder (given you marked your test cases accordingly@pytest.mark.run_only_on('CPU')).bash tools/text_processing_deployment/export_grammars.sh --MODE=test ...pytestand Sparrowhawk here.__init__.pyfor every folder and subfolder, includingdatafolder which has .TSV files?Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.to all newly added Python files?Copyright 2015 and onwards Google, Inc.. See an example here.try import: ... except: ...) if not already done.PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.