Skip to content

test(grpc): reduce unused handlers in CLI gateway mocks #5732

Closed

Description

@TaylorMutch

User Story

While taking over OpenShell's SPIFFE runtime identity PR, I encountered CLI test servers that required unrelated RPC implementations. I need to extend gateway RPCs without adding unused handlers to every CLI mock.

Description

Let partial CLI gRPC test servers implement only the RPCs their tests exercise. Omitted methods should return gRPC UNIMPLEMENTED, while production service implementations must continue to implement every RPC explicitly.

Context

The SPIFFE work merged in #4732 exposed this maintenance cost. Several CLI integration fixtures repeat hundreds of lines of unused handlers, including provider access-token methods unrelated to the tests. This task covers the test infrastructure cleanup separately from the merged feature.

Definition of Done

  • Partial test servers reuse the current public protobuf messages and RPC paths.
  • Unused unary and streaming methods return UNIMPLEMENTED.
  • Production service traits retain exhaustive implementation requirements.
  • Existing synthetic CLI gateway fixtures use the shared defaults, preserving intentional custom errors and stream behavior.
  • Affected integration tests pass and the test helper is documented.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions