Skip to content

fix(e2e): use provider identity for managed credential paths - #3202

Open
shiju-nv wants to merge 1 commit into
NVIDIA:mainfrom
shiju-nv:fix/2983-credential-driver-e2e-identity
Open

fix(e2e): use provider identity for managed credential paths#3202
shiju-nv wants to merge 1 commit into
NVIDIA:mainfrom
shiju-nv:fix/2983-credential-driver-e2e-identity

Conversation

@shiju-nv

@shiju-nv shiju-nv commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Summary

The credential-driver E2E test calculates managed Kubernetes Secret names and Vault paths using only the provider name and credential key. The credential drivers also include the provider workspace and provider ID, so the test can look for an object the driver never created and report a false failure.

Read the stored provider identity and derive the expected storage paths from the same four values used by the drivers:

  • Provider workspace
  • Provider ID
  • Provider name
  • Credential key

This changes only the E2E test. Production credential handling, APIs, policy behavior, and storage formats are unchanged.

Related Issue

Fixes #2983.

Changes

  • Read the created provider's ID and workspace from provider list --output json.
  • Calculate the managed credential hash from workspace, provider ID, provider name, and credential key.
  • Use that hash for both the Kubernetes Secret and Vault path assertions.
  • Keep the existing assertions for credential contents and cleanup behavior.

The core correction was extracted from Drew Newberry's signed commit 10dbe53b1 in #1868.

Testing

  • mise run pre-commit passes
  • Unit tests added/updated (not applicable: this changes an existing E2E test)
  • E2E tests added/updated (if applicable)

Checklist

  • Follows Conventional Commits.
  • Commits are signed off (DCO).
  • Architecture docs updated (not applicable: this changes only an E2E test).

Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Shiju <shiju@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

credential-drivers e2e computes a stale 2-field managed path; the suite cannot pass on main

2 participants