fix(cli): reconcile provisional container exits - #3204
Open
shiju-nv wants to merge 1 commit into
Open
Conversation
shiju-nv
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
September 5, 2026 21:41
Keep watching briefly when a compute driver reports ContainerExited without a canonical main-process result. This prevents --no-keep cleanup from deleting the sandbox before the supervisor publishes the authoritative exit status. Signed-off-by: Shiju <shiju@nvidia.com>
shiju-nv
force-pushed
the
fix/canonical-main-exit-race
branch
from
September 5, 2026 22:22
ecb539f to
223c245
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Treat a driver-reported
ContainerExitedwithout a canonical main-process result as provisional for a bounded five-second reconciliation window. This preventssandbox create --no-keepfrom deleting a fast finite-command sandbox before the supervisor can publish its authoritative exit status, while preserving the concrete driver error when no supervisor result arrives.Related Issue
No issue required: this is an obvious localized bug fix for the intermittent
Release DevRust Docker E2E failure and completes the CLI side of the lifecycle reconciliation introduced by PR #3101.Changes
Errorsandboxes withReady=False, reasonContainerExited, and no exit code as provisional duringsandbox create.ContainerExiteddiagnostic when reconciliation expires.--no-keepcleanup and a missing-result deadline.Testing
mise run pre-commitpassesChecklist