Repository navigation
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
drew
force-pushed
the
fix/4850-supervisor-reconciler-leadership/drew
branch
from
October 22, 2026 22:39
484d04d to
5c3fcb3
Compare
drew
force-pushed
the
feat/4731-stable-sandbox-spiffe/drew
branch
from
October 22, 2026 22:40
eeeacfe to
157478e
Compare
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
TaylorMutch
approved these changes
Oct 23, 2026
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
drew
marked this pull request as ready for review
October 23, 2026 04:02
|
Label |
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
drew
merged commit Oct 23, 2026
6b0466e
into
feat/4731-stable-sandbox-spiffe/drew
97 of 106 checks passed
drew
added a commit
that referenced
this pull request
Oct 23, 2026
maemayv
pushed a commit
to maemayv/OpenShell
that referenced
this pull request
Nov 18, 2026
) * feat(gateway): broker stable sandbox SPIFFE provider tokens Signed-off-by: Drew Newberry <anewberry@nvidia.com> * refactor(gateway): rename SPIFFE delegation configuration Signed-off-by: Drew Newberry <anewberry@nvidia.com> * fix(provider): reuse broker channels and attribute grant failures Signed-off-by: Drew Newberry <anewberry@nvidia.com> * test(provider): satisfy broker logging lint checks Signed-off-by: Drew Newberry <anewberry@nvidia.com> * fix(provider): harden broker caching and deployment prerequisites Signed-off-by: Drew Newberry <anewberry@nvidia.com> * refactor(identity): extract SPIRE sandbox identity adapter Signed-off-by: Drew Newberry <anewberry@nvidia.com> * refactor(identity): move shared SPIFFE types out of core Signed-off-by: Drew Newberry <anewberry@nvidia.com> * fix(supervisor): follow the sandbox reconciler leader (NVIDIA#4853) * chore(sdk): drop regenerated frozen Go bindings Signed-off-by: Taylor Mutch <taylormutch@gmail.com> * test(spiffe): verify provider tokens across supervisor failover Signed-off-by: Taylor Mutch <taylormutch@gmail.com> * feat(crypto): verify TLS peers by SPIFFE identity Signed-off-by: Taylor Mutch <taylormutch@gmail.com> * feat(spiffe): use Broker API for sandbox identity issuance Signed-off-by: Taylor Mutch <taylormutch@gmail.com> * test(spiffe): verify broker authorization and credential rotation Signed-off-by: Taylor Mutch <taylormutch@gmail.com> * docs(spiffe): clean up broker troubleshooting and test wording Signed-off-by: Taylor Mutch <taylormutch@gmail.com> * feat(spiffe): authorize Broker agents across Kubernetes nodes Signed-off-by: Taylor Mutch <taylormutch@gmail.com> * fix(spiffe): send canonical credential keys to the gateway Signed-off-by: Taylor Mutch <taylormutch@gmail.com> * perf(providers): resolve only the requested token grant profile Signed-off-by: Taylor Mutch <taylormutch@gmail.com> * fix(providers): bound broker admission and refresh expired cache hits Signed-off-by: Taylor Mutch <taylormutch@gmail.com> * chore(server): remove unused protobuf codec dependency Signed-off-by: Taylor Mutch <taylormutch@gmail.com> * fix(spiffe): classify identity failures without retrying configuration errors Signed-off-by: Taylor Mutch <taylormutch@gmail.com> * fix(spiffe): unify gateway identity configuration and document shared grants Signed-off-by: Taylor Mutch <taylormutch@gmail.com> * test(providers): verify targeted snapshot freshness and cache reuse Signed-off-by: Taylor Mutch <taylormutch@gmail.com> * test(spiffe): support remote fixtures and remove CSI consumers before teardown Signed-off-by: Taylor Mutch <taylormutch@gmail.com> * fix(providers): validate uncached sources before selecting a grant Signed-off-by: Taylor Mutch <taylormutch@gmail.com> * test(spiffe): validate agent replacement and remote supervisor failover Signed-off-by: Taylor Mutch <taylormutch@gmail.com> * feat(spiffe): connect the gateway to its node-local Broker agent Signed-off-by: Taylor Mutch <taylormutch@gmail.com> * test(spiffe): validate node-local Broker routing across gateway relocation Signed-off-by: Taylor Mutch <taylormutch@gmail.com> * fix(ci): satisfy certificate test lint and refresh merged lockfile Signed-off-by: Taylor Mutch <taylormutch@gmail.com> * test(crypto): initialize OpenSSL for SPIFFE certificate verification Signed-off-by: Taylor Mutch <taylormutch@gmail.com> * chore(spiffe): remove prototype tooling and stale guidance Signed-off-by: Taylor Mutch <taylormutch@gmail.com> * fix(providers): share acquisition failures with waiting requests Signed-off-by: Taylor Mutch <taylormutch@gmail.com> * fix(core): initialize provider-token channels without eager connects Signed-off-by: Taylor Mutch <taylormutch@gmail.com> --------- Signed-off-by: Drew Newberry <anewberry@nvidia.com> Signed-off-by: Taylor Mutch <taylormutch@gmail.com> Co-authored-by: Taylor Mutch <taylormutch@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make the existing sandbox reconciler leader own shared-supervisor assignment publication. A supervisor connecting to a standby retries through the gateway endpoint, and a replacement leader recovers durable assignments before publishing while hosted instances keep running.
Stacked on #4732; #4702 is merged into
main. This coordinates gateway ownership of one shared supervisor without another election, supervisor HA, or scheduling.Closes #4850
Changes
Attachrefusals with private gRPC metadata. Retry them on a fresh connection after 250–999 ms of jitter; preserve exponential backoff for other failures and cancellation on shutdown.The gateway endpoint must balance across eligible replicas without affinity pinning the supervisor to a standby. Standby admission is eventual: the leader discovers durable creates and withdrawals through existing driver reconciliation, and over-capacity creates follow the existing supervision-failure path. Readiness can lag lease renewals, standby polls, and driver reconciliation. Single-replica storage retains local publication.
Validation
-D warningspassed for the SPIFFE types, SPIRE adapter, core, supervisor-network, supervisor-control, server, gateway, Kubernetes driver, and supervisor, including servertest-support.cargo check --locked --manifest-path e2e/rust/Cargo.toml --all-targets --features e2e-kubernetes-shared-supervisor).openshell-spire, behindopenshell-spiffe::SandboxIdentityProvider; its focused adapter, core SPIFFE, and server tests passed.The underlying layer also passed 367 Helm tests and the live local SPIRE 1.15.4 delegated-identity fixture. Full Kubernetes/PostgreSQL failover and Kubernetes/SPIRE E2E were not run. The local two-runtime lease-transfer test uses shared SQLite storage.