Skip to content

fix(ci): repair Windows VM runtime and K3s installer pins - #5736

Merged
shailendra-nv merged 2 commits into
windowsfrom
fix/5734-windows-ci-pins/shailendra-nv
Nov 19, 2026
Merged

shailendra-nv merged 2 commits into
windowsfrom
fix/5734-windows-ci-pins/shailendra-nv

Conversation

@shailendra-nv

Copy link
Copy Markdown
Collaborator

Summary

Repair stale CI download pins on windows so VM builds and K3s conformance can bootstrap. The three VM-runtime hashes match the published release assets and upstream main; the K3s installer is fetched from its configured release tag instead of the mutable get.k3s.io URL.

Related Issue

Closes #5734

Extracted from #5327 so the CI repairs land independently before the supervisor change. Author access to NVIDIA/OpenShell was verified as MAINTAIN; the linked maintenance issue does not yet have state:accepted.

Changes

  • Cherry-pick the VM-runtime hash repair from 3df4002a2 (now dc1f2efe3), matching upstream 59ddef65 and a4c848ad.
  • Cherry-pick the K3s installer URL/checksum repair from 9dbf16901 (now 2f5d2ed28), following upstream fix(tests): pin the k3s installer to a release #5223.
  • Preserve all artifact versions, including K3s 1.36.3+k3s1. Only nix/pkgs/vm-runtime.nix and tests/ansible/playbooks/k3s.yaml change.

Testing

  • Verified both changed files are byte-identical to the files tested on fix(supervisor): reject unsupported live filesystem policy changes #5327 at 9dbf1690105292a4bb6681fb7bfaf2ee3e577bc6; git diff --check passed on this branch.
  • Verified VM hashes against official release digests and the K3s checksum against the exact release installer; YAML parsing and retained-version checks passed.
  • Attach existing CI evidence below. These runs tested fix(supervisor): reject unsupported live filesystem policy changes #5327 at 9dbf16901, rather than this cherry-picked head 2f5d2ed28 on Windows base 054b3a6b7. The operator explicitly requested reusing these results and merging without rerunning CI on this standalone PR.
  • Unit/E2E test source changes: not applicable to the pin-only repair.

Existing results on the tested source commit:

  • Branch Checks: passed; Linux x64/ARM64 and macOS ARM64 Rust jobs recorded 24,001 passed test executions and 95 skipped.
  • Windows MSVC x64 and ARM64: passed.
  • External /windows-ci ARM64 report and full log: check, release build, workspace/unsupported-driver tests, selective feature configurations, artifact verification, and packaging all passed.
  • Full E2E: passed, including all three VM-driver builds, both VM E2E suites, and single-node/HA K3s conformance. The first single-node job passed every assertion, then timed out during QEMU teardown; its targeted retry passed completely. No harness changes were made.

Windows test executions in that evidence (intentional reruns included, filtered-out and compile-time-disabled tests excluded):

Suite Total Passed Skipped Failed
GitHub x64 workspace 6,704 6,661 43 0
GitHub ARM64 workspace 6,704 6,661 43 0
External ARM64 workspace 6,704 6,661 43 0
External ARM64 unsupported built-in drivers 1 1 0 0
External ARM64 default registry contract 1 1 0 0
External ARM64 selective feature matrix (four configurations) 8 8 0 0
Total 20,122 19,993 129 0

Local validation limitation: the broad commit hook could not build unrelated grpcio-tools==1.78.0 on native Windows ARM64/Python 3.14. Scoped pin validation and the linked full CI supplied verification; no permanent hook settings changed.

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Related contributor workflows reviewed; no commands, skill coverage, or user-facing behavior change

Use the published VM runtime hashes already corrected on main by 59ddef6 and a4c848a so VM E2E builds can fetch their runtime dependencies.

Signed-off-by: Shailendra Singh <shailendras@nvidia.com>
Fetch the installer for the configured K3s v1.36.3+k3s1 release and verify its SHA-256, following the upstream fix in #5223.

Signed-off-by: Shailendra Singh <shailendras@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Nov 19, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions Bot added the state:accepted A maintainer decided OpenShell should pursue this issue label Nov 19, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-19T00:08:56.922560Z 2f5d2ed PR opened
🔒 Security Review ❌ Failed 2026-11-19T00:08:42.497768Z
We couldn’t complete this review. Comment @codex security review to try again.
2f5d2ed PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@shailendra-nv
shailendra-nv merged commit f0db2ee into windows Nov 19, 2026
13 of 15 checks passed
@shailendra-nv
shailendra-nv deleted the fix/5734-windows-ci-pins/shailendra-nv branch November 19, 2026 00:08
shailendra-nv pushed a commit that referenced this pull request Nov 19, 2026
…5327)

Reject live filesystem policy changes that cannot affect the running sandbox. Compare candidates against the filesystem policy installed at startup, restoring only the proxy baseline paths installed there, so global-policy retries and network-only updates continue to load.

Report rejected revisions through the existing policy validation failure handling and document that filesystem changes require sandbox recreation. Include regression coverage for sandbox/global policies, retries, reordered paths, and recovery.

The CI pin repairs were merged separately in #5736. Existing CI verification and review are recorded on this PR.

Closes #5326

Signed-off-by: Rahool Paliwal <rpaliwal@nvidia.com>
Signed-off-by: Shailendra Singh <shailendras@nvidia.com>
shailendra-nv added a commit to nv-rahool/OpenShell that referenced this pull request Nov 19, 2026
Apply the VM runtime hashes and K3s installer pin already merged into windows in NVIDIA#5736. The runtime hashes match the published release asset digests.

Signed-off-by: Shailendra Singh <shailendras@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state:accepted A maintainer decided OpenShell should pursue this issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant