Repository navigation
fix(ci): repair Windows VM runtime and K3s installer pins - #5736
Merged
Merged
Conversation
Fetch the installer for the configured K3s v1.36.3+k3s1 release and verify its SHA-256, following the upstream fix in #5223. Signed-off-by: Shailendra Singh <shailendras@nvidia.com>
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
5 of 6 tasks
shailendra-nv
pushed a commit
that referenced
this pull request
Nov 19, 2026
…5327) Reject live filesystem policy changes that cannot affect the running sandbox. Compare candidates against the filesystem policy installed at startup, restoring only the proxy baseline paths installed there, so global-policy retries and network-only updates continue to load. Report rejected revisions through the existing policy validation failure handling and document that filesystem changes require sandbox recreation. Include regression coverage for sandbox/global policies, retries, reordered paths, and recovery. The CI pin repairs were merged separately in #5736. Existing CI verification and review are recorded on this PR. Closes #5326 Signed-off-by: Rahool Paliwal <rpaliwal@nvidia.com> Signed-off-by: Shailendra Singh <shailendras@nvidia.com>
4 tasks done
shailendra-nv
added a commit
to nv-rahool/OpenShell
that referenced
this pull request
Nov 19, 2026
Apply the VM runtime hashes and K3s installer pin already merged into windows in NVIDIA#5736. The runtime hashes match the published release asset digests. Signed-off-by: Shailendra Singh <shailendras@nvidia.com>
12 of 13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Repair stale CI download pins on
windowsso VM builds and K3s conformance can bootstrap. The three VM-runtime hashes match the published release assets and upstreammain; the K3s installer is fetched from its configured release tag instead of the mutableget.k3s.ioURL.Related Issue
Closes #5734
Extracted from #5327 so the CI repairs land independently before the supervisor change. Author access to NVIDIA/OpenShell was verified as
MAINTAIN; the linked maintenance issue does not yet havestate:accepted.Changes
3df4002a2(nowdc1f2efe3), matching upstream59ddef65anda4c848ad.9dbf16901(now2f5d2ed28), following upstream fix(tests): pin the k3s installer to a release #5223.1.36.3+k3s1. Onlynix/pkgs/vm-runtime.nixandtests/ansible/playbooks/k3s.yamlchange.Testing
9dbf1690105292a4bb6681fb7bfaf2ee3e577bc6;git diff --checkpassed on this branch.9dbf16901, rather than this cherry-picked head2f5d2ed28on Windows base054b3a6b7. The operator explicitly requested reusing these results and merging without rerunning CI on this standalone PR.Existing results on the tested source commit:
/windows-ciARM64 report and full log: check, release build, workspace/unsupported-driver tests, selective feature configurations, artifact verification, and packaging all passed.Windows test executions in that evidence (intentional reruns included, filtered-out and compile-time-disabled tests excluded):
Local validation limitation: the broad commit hook could not build unrelated
grpcio-tools==1.78.0on native Windows ARM64/Python 3.14. Scoped pin validation and the linked full CI supplied verification; no permanent hook settings changed.Checklist