Repository navigation
Keep E1 upload flags within proved command boundaries - #841
Open
chrisknvidia wants to merge 1 commit into
Open
chrisknvidia wants to merge 1 commit into
chrisknvidia wants to merge 1 commit into
Conversation
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
chrisknvidia
marked this pull request as ready for review
October 16, 2026 05:38
Collaborator
Author
|
Ready for review at All six hosted CI checks have passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #838.
A health-check
curlcan currently consume-dfrom a later, independent Docker command and report E1 External Transmission. Limit curl/wget upload-pattern matching to proved command spans so separate LF/CRLF commands and Markdown examples keep their own flags. Preserve multiline uploads and derive locations and fingerprints from original source text. Corrected multi-command spans can change existing fingerprints; baseline generation and rescans are covered.Reuse the bounded shell tokenizer and retain existing matching for uncertain syntax, including ambiguous same-line semicolon/hash boundaries, Windows shell constructs, malformed input and overlapping nested candidates. Other E1 patterns retain their behavior. The original Docker example can still produce an independent RP1 finding.
Validation on this head: 827 focused tests, 47 installed-wheel CLI checks and five real MCP stdio calls passed. The CLI matrix covers JSON/SARIF, strict exit policy, referenced shell files and baseline generation/suppression. Independent review verified the actual reports and installed package identity. Targeted mypy and source/test Ruff lint and formatting passed. All six hosted checks passed. Additional independent code/security review passed, including 13 native Bash argument-capture comparisons, bounded repeated-fetch timing, and actual installed-console JSON/SARIF scans for redirection, process substitution, parameter expansion and background commands. Native Windows shell execution was not run.
This overlaps #741 in E1 matcher infrastructure. Whichever change lands second must preserve both command boundaries and cumulative matching budgets, including anchored matching. This branch targets current main; combined integration with #741 has not been validated.