Repository navigation
fix: avoid checksum false positives and preserve archive error origins - #844
Merged
mohgupta-ship-it merged 5 commits intoOct 16, 2026
Merged
Conversation
Signed-off-by: yashrajbasav <yashrajbasav@nvidia.com>
Signed-off-by: yashrajbasav <yashrajbasav@nvidia.com>
Signed-off-by: yashrajbasav <yashrajbasav@nvidia.com>
yashrajp22
marked this pull request as draft
October 15, 2026 09:19
…ings Signed-off-by: yashrajbasav <yashrajbasav@nvidia.com>
yashrajp22
marked this pull request as ready for review
October 15, 2026 09:28
mohgupta-ship-it
deleted the
yashraj/fix-release-scan-regressions-20261015
branch
October 16, 2026 06:49
yashrajp22
pushed a commit
that referenced
this pull request
Oct 16, 2026
…ons-20261015 fix: avoid checksum false positives and preserve archive error origins (cherry picked from commit e8850a8) Signed-off-by: yashrajbasav <yashrajbasav@nvidia.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two issues found while checking the release wheel:
sha256sumno longer produces a false SC2 remote-execution finding in a simple checksum context. Saved payloads and later execution retain their findings. Alias/function definitions, escaped shell words and uncertain command syntax keep conservative analysis; shell context is normalized at most once per input.Follow-up to #786 and #793, intended for v2.13.0 in #833 after review. These changes are not yet included in the release branch.
Validation
Compared
240421219409dc0bafef9f618a10d80c2d7e83a3with885e619043f9f833c33702d72f64fdc0400eda43:Candidate wheel SHA-256:
408bf6606b89ae2c4a1539d3e35641ef7952d48f59fc0f49ee24c26f09cf21d9.Independent static review covers the final commit. Greptile feedback on earlier revisions was adjudicated and the confirmed saved-payload and fragmented-alias cases have regression coverage. CodeRabbit returned a service error; no completed CodeRabbit review is claimed.
This is scoped offline regression evidence. No live-provider calls were made, and the previously observed provider-budget timeouts are unchanged.