Repository navigation
Conversation
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one): 1
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
tpn
force-pushed
the
codex/xpois-lazy-fits-main-20260930
branch
from
October 5, 2026 02:43
0f278f7 to
bedf42f
Compare
tpn
force-pushed
the
codex/xfit-cupy-fusion-publish-20260930
branch
from
October 5, 2026 02:48
4b8f875 to
81526f2
Compare
tpn
force-pushed
the
codex/xpois-lazy-fits-main-20260930
branch
from
October 9, 2026 19:12
bedf42f to
e91c262
Compare
tpn
force-pushed
the
codex/xfit-cupy-fusion-publish-20260930
branch
from
October 9, 2026 20:44
81526f2 to
280d818
Compare
tpn
force-pushed
the
codex/xfit-cupy-fusion-publish-20260930
branch
2 times, most recently
from
October 15, 2026 18:05
f48b35f to
dfdd55b
Compare
Add opt-in kernels that combine Gaussian evaluation, weighting and normal-equation accumulation while retaining the existing LM solver. Expose fusion through the fit API, CLI and device pipeline settings. Signed-off-by: Trent Nelson <trentn@nvidia.com>
Use explicit rounding at pointwise operation boundaries while retaining the default library math and CuPy normal-equation contractions. This preserves sensitive Gaussian fits and covers cancelling derivatives. Signed-off-by: Trent Nelson <trentn@nvidia.com>
Signed-off-by: Trent Nelson <trentn@nvidia.com>
Signed-off-by: Trent Nelson <trentn@nvidia.com>
Signed-off-by: Trent Nelson <trentn@nvidia.com>
tpn
force-pushed
the
codex/xfit-cupy-fusion-publish-20260930
branch
from
October 16, 2026 18:47
dfdd55b to
7a4a32b
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gaussian CuPy fits launch many small operations to evaluate residuals and analytic derivatives. Add opt-in CuPy kernels that combine those operations while keeping the existing normal-equation contractions, LM solver, and final uncertainty diagnostics.
The CLI selects the same implementation with
--backend cupy --fusion, and device pipeline manifests acceptxfit.fusion: true. Float32/float64, masks, variances, difference mode, and split mode are supported. Each fit owns its buffers and uses the current CuPy stream. Explicit rounding preserves the arithmetic boundaries that matter for ill-conditioned fits.The public Gaussian benchmark now reports the first fit separately from every warmed sample. Run it with and without
--fusionto compare complete fits, including input transfer and portable results.Local validation: all 43 selected GPU cases passed without skips, covering fusion, numerical edge cases, independent streams, repeated calls, and the actual CLI. The integrated source also passed 545 CPU tests (94 expected GPU/optional skips) and repository hooks, including Ruff and mypy.