Skip to content

Reduce redundant host work in the xFit LM solver - #92

Open
tpn wants to merge 1 commit into
codex/numba-xfit-main-20260930from
codex/numba-xfit-host-20260930
Open

tpn wants to merge 1 commit into
codex/numba-xfit-main-20260930from
codex/numba-xfit-host-20260930

Conversation

@tpn

@tpn tpn commented Oct 1, 2026 •

Copy link
Copy Markdown
Collaborator

The normal-equation path copied five arrays even when every row was valid,
and filtered trial-evaluation budgets after analytic Jacobians that consume no
residual evaluations. Skip those operations to reduce repeated host work in
xFit's shared solver. Preserve fallback filtering and finite-difference budget
checks, with a regression for exhausting the budget just before a trial in both
implicit and explicitly requested finite-difference modes. Builds on #85.

Validation on the integrated source (Python 3.12, CUDA 13):

  • 712 CPU tests passed, including solver budget, shared execution, and pipeline coverage.
  • All 70 native and Numba scientific, CLI, and end-to-end pipeline tests passed without skips.
  • All-file hooks passed with the optional GPU and Numba dependencies installed, including mypy and lock validation.

Earlier free-threaded Python 3.14 testing with Numba-CUDA-MLIR 0.5.4 exposed
an intermittent concurrent-startup failure in dependency type dispatch.
These Python 3.12 runs do not qualify free-threaded concurrent-startup reliability.

@tpn
tpn requested a review from melo-gonzo as a code owner October 1, 2026 08:38
@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one): 1
  • ai-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: NVIDIA/cuPhoton/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: eccb0e59-7700-4e2a-bc4c-d8716567134d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@tpn
tpn force-pushed the codex/numba-xfit-main-20260930 branch from 08a39e6 to cd776e0 Compare October 5, 2026 02:48
@tpn
tpn force-pushed the codex/numba-xfit-host-20260930 branch from d544aaf to 20b65af Compare October 5, 2026 02:48
@tpn
tpn force-pushed the codex/numba-xfit-main-20260930 branch from cd776e0 to bed540e Compare October 9, 2026 20:46
@tpn
tpn force-pushed the codex/numba-xfit-host-20260930 branch from 20b65af to 009ed32 Compare October 9, 2026 20:46
@tpn
tpn force-pushed the codex/numba-xfit-main-20260930 branch from bed540e to 0bd3868 Compare October 9, 2026 21:09
@tpn
tpn force-pushed the codex/numba-xfit-host-20260930 branch 2 times, most recently from 4ccd920 to 63b7967 Compare October 15, 2026 18:05
@tpn
tpn force-pushed the codex/numba-xfit-main-20260930 branch from 0bd3868 to 9aa4b56 Compare October 15, 2026 18:05
Filter normal-equation rows only when a fallback was needed.
Skip the second residual-budget filter for analytic derivatives;
keep it for finite differences, with a boundary regression test.

Signed-off-by: Trent Nelson <trentn@nvidia.com>
@tpn
tpn force-pushed the codex/numba-xfit-main-20260930 branch from 9aa4b56 to d940e53 Compare October 16, 2026 18:47
@tpn
tpn force-pushed the codex/numba-xfit-host-20260930 branch from 63b7967 to 2b2222c Compare October 16, 2026 18:47

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant