You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! I don't think we want to burn resources this much for pre-release software on a per-PR basis. Could you keep 3.15/3.15t to nightly-standard rows only?
No actionable comments were generated in the recent review.
Summary
Summary by CodeRabbit
Tests
Expanded nightly test coverage for CUDA 13.5 across arm64 and amd64 systems, adding Python 3.15 and 3.15t configurations. Coverage now includes A100 GPU configurations on both platforms and an L4 configuration on arm64. These changes apply to automated testing; they do not add or change product features.
The Linux nightly-standard matrix adds four CUDA 13.5.0 test rows for Python 3.15 and 3.15t. The rows cover arm64 and amd64 configurations using A100 or L4 GPUs.
The matrix adds four Python 3.15 or 3.15t rows for Linux nightly-standard tests with CUDA 13.5.0.
Assessment against linked issues
Objective
Addressed
Explanation
Build and test Python 3.15 pre-releases in CI [#2163]
✅
Change: Other
Merge Risk: Low · up to ca1ca
This change adds Python 3.15 nightly test rows. The amd64 rows are likely never run, because the nightly-standard job targets only arm64. Nothing in production is affected, but the intended amd64 coverage is probably missing. Add an amd64 nightly job or remove those rows.
Security architecture risk: Minimal · up to ca1ca
The added test configurations reuse existing runner selection, permissions, and CUDA download controls. They do not enable host driver reconfiguration. No introduced or worsened architecture-level security risk was established.
Finishing Touches
Fix failing CI checks
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Reviewing files that changed from the base of the PR and between 249d73c and ca1ca36.
Files selected for processing: 1
ci/test-matrix.yml
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.
Reviewing files that changed from the base of the PR and between c7e6f09 and 249d73c.
📒 Files selected for processing (2)
ci/test-matrix.yml
ci/tools/download-wheels
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
suggestion: Route the amd64 entries to a nightly-standard job.
ci-nightly.yml runs nightly-standard only for linux-aarch64. The shared Linux workflow filters matrix entries by the requested architecture. These amd64 rows are therefore never selected and add no amd64 Python 3.15 or 3.15t test coverage. Add a linux-64 nightly-standard job or remove the unused rows. (raw.githubusercontent.com)
As per path instructions: “focus on matrix correctness” and “targeted build and test behavior.”
The reason will be displayed to describe this comment to others. Learn more.
Additional comments: 1
ci/test-matrix.yml-126-127: 1
126-127: Minor · Performance & Scalability · Quick win
Unverified finding
Verification ran but could not confirm this finding. It is shown for review, not as a verified issue.
important: Avoid repeating the arm64 GPU jobs.
Lines 91 and 93 already run these configurations in the scheduled full CI. The nightly workflow repeats the standard tests on the same runner types, adding two GPU jobs without a distinct configuration. Remove these rows or use nightly-only configurations. (raw.githubusercontent.com)
As per path instructions: “avoid unnecessary expensive jobs.”
Reviewing files that changed from the base of the PR and between 249d73c and 36b6bb9.
Files selected for processing: 1
ci/test-matrix.yml
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI/CDCI/CD infrastructurecuda.bindingsEverything related to the cuda.bindings modulecuda.coreEverything related to the cuda.core modulecuda.pathfinderEverything related to the cuda.pathfinder moduleP2Low priority - Nice to have
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closes #2163
Checklist