-
Notifications
You must be signed in to change notification settings - Fork 329
test(cuda.bindings): restore thread_unsafe marker for cuFile stats level #2812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+35
−2
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,20 @@ | ||
| # SPDX-FileCopyrightText: Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-FileCopyrightText: Copyright (c) 2025-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| import functools | ||
| import importlib.metadata | ||
| import re | ||
|
|
||
| from packaging.version import Version | ||
|
|
||
|
|
||
| @functools.cache | ||
| def have_distribution(name_pattern: str) -> bool: | ||
| def have_distribution(name_pattern: str, *, minimum_version: str | None = None) -> bool: | ||
| re_name_pattern = re.compile(name_pattern) | ||
| parsed_minimum_version = Version(minimum_version) if minimum_version is not None else None | ||
| return any( | ||
| re_name_pattern.match(dist.metadata["Name"]) | ||
| and (parsed_minimum_version is None or Version(dist.version) >= parsed_minimum_version) | ||
| for dist in importlib.metadata.distributions() | ||
| if "Name" in dist.metadata | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test feels a bit redundant, but maybe some small value for
have_distributiongetting this logic wrong.(It might make sense to check on successful load that
_is_expected_load_nvidia_dynamic_lib_failureisn't True. But I think the function isn't strict it just says if a failure is acceptable).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This came from #2809, which I had to include here for the CI to pass, but it was merged before this PR. The net change in this PR is only the one-line addition of the marker (
git show51ec66b after this PR was merged).I agree the test is more defensive than what a human would write, but it's not wrong, and trimming back the defensiveness takes time, so I often/usually leave it as-is; it's clearly marked as agent-generated.