Skip to content

Prepare cuda-bindings 12.9.8 release - #2814

Merged
mdboom merged 8 commits into
NVIDIA:12.9.xfrom
mdboom:release-12.9.x
Sep 14, 2026
Merged

mdboom merged 8 commits into
NVIDIA:12.9.xfrom
mdboom:release-12.9.x

Conversation

@mdboom

@mdboom mdboom commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Regenerate files and add release notes for cuda-bindings 12.9.8

@github-actions github-actions Bot added the cuda.bindings Everything related to the cuda.bindings module label Sep 11, 2026
@mdboom
mdboom requested a review from leofang September 11, 2026 12:23
@mdboom mdboom self-assigned this Sep 11, 2026
@mdboom mdboom added this to the cuda.bindings 13.4.0 & 12.9.8 milestone Sep 11, 2026
@github-actions github-actions Bot added the CI/CD CI/CD infrastructure label Sep 11, 2026

@rwgk rwgk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still looking with codex as well.

Prerelease feature
------------------

A new version of the ``nvrtc`` API is available as ``cuda.bindings._v2.nvrtc``. The

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
A new version of the ``nvrtc`` API is available as ``cuda.bindings._v2.nvrtc``. The
This release introduces an experimental, alternative ``cuda.bindings._v2.nvrtc`` API. The

The main idea is to insert the word "experimental" early.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correction after checking the branch and the PR-built wheel: it seems this whole section should be removed. _v2.nvrtc is a 13.4-only preview API and is not packaged by 12.9.x.

Comment on lines +34 to +35
Prerelease feature
------------------

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xref: #2836

Suggested change
Prerelease feature
------------------
Preview feature
---------------

Comment on lines +12 to +26
(`PR #2581 <https://github.com/NVIDIA/cuda-python/pull/2581>`_)
* Fixed a crash in ``nvml.system_event_set_wait`` caused by calling
``resize()`` on a non-owning ``SystemEventData_v1._data`` view.
(`PR #2690 <https://github.com/NVIDIA/cuda-python/pull/2690>`_)
* ``get_cuda_native_handle`` no longer misreports a ``KeyError`` raised from
within a registered getter as an "Unknown type" error.
(`PR #2551 <https://github.com/NVIDIA/cuda-python/pull/2551>`_)
* Fixed ``cuFile`` status checking to no longer raise ``cuFileError``
spuriously when ``CUfileError_t.cu_err`` is set on a non-error path (for
example, BAR-size queries on GH200 systems).
(`PR #2530 <https://github.com/NVIDIA/cuda-python/pull/2530>`_)
* Made ``param_packer.feed()`` safe under free-threaded Python by moving its
internal state initialization to import time.
(`PR #2417 <https://github.com/NVIDIA/cuda-python/pull/2417>`_)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The formatting here seems off? PR XXXX comes before the bullet point

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also it doesn't seem that the style is consistent with past release notes (we don't link to PRs), although this is just a minor nit

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is at the end of each bullet point.

Precedent for adding PR numbers is all throughout the 13.3 release notes. https://raw.githubusercontent.com/NVIDIA/cuda-python/refs/heads/main/cuda_bindings/docs/source/release/13.3.0-notes.rst

@leofang leofang left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: We probably should also update cuda_python/docs in this branch?

@rwgk rwgk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cibuildwheel 4.2.0 bump means the cp315/cp315t wheels are now built with CPython 3.15.0rc1, but the post-build/test environments still force 3.15.0-beta.2 in:

  • .github/workflows/build-wheel.yml:233
  • .github/workflows/test-wheel-linux.yml:220
  • .github/workflows/test-wheel-windows.yml:210

This crosses a prerelease ABI change and is now causing all six 3.15/3.15t wheel-test jobs to crash during extension import—segmentation faults on Linux and access violations on Windows. Could we update or remove these three beta.2 overrides so the build and test interpreters match?


``cuda-bindings`` 12.9.8 Release notes
======================================

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to have been based on the 13.4.1 notes rather than the changes actually shipped on 12.9.x. The #2581, #2551, and #2417 changes and the _v2.nvrtc preview API (#2398) are not present on this branch; #2690 and #2530 are present. Conversely, actual changes since v12.9.7 such as #2145 and #2382 are not mentioned. Could we rebuild these notes from the v12.9.7..12.9.x history and remove the _v2 section?

Also, I think this new page needs to be linked from cuda_bindings/docs/source/release.rst.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I think this new page needs to be linked from cuda_bindings/docs/source/release.rst.

The docs are not actually shipped from this branch, so that file hasn't been updated in a long time. I instead just think we put the new release notes for 12.9.8 here (with the corrections you outlined) and then file another PR to copy it to main.

@mdboom
mdboom requested review from leofang and rwgk September 14, 2026 15:49
@rwgk rwgk added the PR review get-together Mark PRs you'd like the team to review at the weekly PR review get-together. label Sep 14, 2026
@rwgk

rwgk commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Fresh verdict: the workflow blocker is fixed, but I’d hold approval for one more release-note correction.

The fresh PR head is 8fe688e4287dbb26d5e5a3d95e70113010313bca, matching local HEAD.

Remaining substantive finding

The Bugfixes section still differs from the actual release delta in three ways:

  1. It accidentally dropped the valid cuda.bindings: Fix API status handling #2530 and nvbug 6602863: system_event_set_wait fails on events: resize() on non-owning SystemEventData_v1._data view #2690 entries.

  2. The #2382 entry says runtime, but that change affected NVVM, not the runtime bindings. This should be runtimeNVVM.

  3. The #2206 entries overstate the delta:

    • The exception-declaration bullet should be removed; v12.9.7 already used the except ?CUDA_ERROR_NOT_FOUND driver signature.
    • FunctionNotFoundError became new for missing driver functions only. NVRTC already raised it in v12.9.7.

I’d post those as one consolidated follow-up on your existing release-note thread:

The rewritten Bugfixes section still has three mismatches with v12.9.7..HEAD:

Could we correct those before merging?

Nonblocking cleanup

  • matrix.python-verison is misspelled, so the free-threaded verification step is skipped even for 3.15t. This predates the PR; I’d treat it as an optional inline cleanup.
  • cuda_core should be cuda.core or cuda-core. I wouldn’t post this separately.

Non-generated files reviewed

The _v2 section and false #2581/#2551/#2417 claims are gone. I would not repeat the release.rst point given Michael’s explanation.

Of 32 changed files, 28 matched the generated-file marker and were excluded. git diff --check is clean. At my final CI refresh, 60 checks passed, one unrelated Windows 3.11 job remained in progress, and none had failed; importantly, all twelve Python 3.15/3.15t build and test jobs now pass.

I did not post any comments.

@mdboom

mdboom commented Sep 14, 2026

Copy link
Copy Markdown
Contributor Author

The only actionable things from that review were putting #2530 and #2690 back in.

@rwgk rwgk removed the PR review get-together Mark PRs you'd like the team to review at the weekly PR review get-together. label Sep 14, 2026
@mdboom
mdboom enabled auto-merge (squash) September 14, 2026 18:03
@mdboom
mdboom merged commit 826f10e into NVIDIA:12.9.x Sep 14, 2026
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD CI/CD infrastructure cuda.bindings Everything related to the cuda.bindings module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants