Skip to content

Reorder GIL/ipc mutex lock in resource_handles.cpp - #2848

Open
brandon-b-miller wants to merge 2 commits into
NVIDIA:mainfrom
brandon-b-miller:fix-2840
Open

Reorder GIL/ipc mutex lock in resource_handles.cpp#2848
brandon-b-miller wants to merge 2 commits into
NVIDIA:mainfrom
brandon-b-miller:fix-2840

Conversation

@brandon-b-miller

Copy link
Copy Markdown
Contributor

Closes #2840 .

@copy-pr-bot

copy-pr-bot Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions Bot added the cuda.core Everything related to the cuda.core module label Sep 14, 2026
@brandon-b-miller brandon-b-miller added the bug Something isn't working label Sep 14, 2026
@Andy-Jost Andy-Jost self-assigned this Sep 14, 2026
@Andy-Jost Andy-Jost added the P0 High priority - Must do! label Sep 14, 2026
@Andy-Jost Andy-Jost added this to the cuda.core 1.3.0 milestone Sep 14, 2026
@Andy-Jost
Andy-Jost self-requested a review September 14, 2026 19:06

@Andy-Jost Andy-Jost left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I will adjust this fix in #2759, where the nearby pw_cuMemFreeAsync needs additional care.

@Andy-Jost

Copy link
Copy Markdown
Contributor

/ok to test

@copy-pr-bot

copy-pr-bot Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

/ok to test

@Andy-Jost, there was an error processing your request: E1

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/

@Andy-Jost

Copy link
Copy Markdown
Contributor

/ok to test 7d2819d

@github-actions

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working cuda.core Everything related to the cuda.core module P0 High priority - Must do!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: Buffer.from_ipc_descriptor deadlocks between ipc_import_mutex and the GIL

2 participants