You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
CI: Restore cuda-python dependency validation in release workflow - #3470
PR #2334 disabled metapackage dependency resolution in artifact-based CI to unblock subpackage releases. Restore this coverage for cuda-python releases by installing the candidate wheel with published PyPI dependencies in clean environments.
Test default and [all] installs across the tagged source's supported Python versions, including free-threaded builds, on Linux x86-64, Linux ARM64, and Windows x86-64. Require binary wheels and run pip check.
Run validation during dry runs and full releases, and require success before asset uploads or package publication. Document that dependencies must reach PyPI before validating the metapackage release.
Validation: workflow/YAML/SPDX/format checks, nine pip scenarios, and 208 release-gating scenarios passed. CI-tool suite: 392 passed; one sandbox UID/signing failure. Full pre-commit stopped on a link-checker download failure. GitHub release dry runs were not executed.
Reviewing files that changed from the base of the PR and between f5681ad and 35356fb.
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
Trigger review
No actionable comments were generated in the recent review.
Summary
Summary by CodeRabbit
Chores
The cuda-python release process now checks installation of the base package and [all] extra from published wheels across supported Python versions and Linux and Windows platforms.
Release assets and TestPyPI publication wait for these checks, including dependency validation, to pass.
Release dry runs for cuda-bindings and cuda-python are now performed separately and in order.
The release workflow adds dependency checks for cuda-python across supported Python versions, platforms, and package extras. Archive upload and TestPyPI publishing now depend on those checks for cuda-python. The release procedure documents separate dry runs and approvals for the two components.
Changes: cuda-python Release Dependency Testing
Layer / File(s)
Summary
Prepare and run dependency checks .github/workflows/release.yml
The workflow exports the supported Python versions and tests base and [all] installs across the configured platforms and versions.
Gate release steps on dependency checks .github/workflows/release.yml, .github/RELEASE-bindings.md
Archive upload and TestPyPI publishing require successful dependency tests for cuda-python. The release procedure specifies per-component dry runs and approvals.
Assessment against linked issues
Objective
Addressed
Explanation
Fix the cuda-python dependency test by running it in the release workflow [#2342]
✅
Suggested reviewers:rwgk
Change: Bug fix
Merge Risk: Minimal · previous review f5681
This change restores dependency validation for cuda-python in the release workflow and requires it to pass before archive upload and TestPyPI publishing. No concrete merge-blocking risk was identified. The release dry run on GitHub runners has not been executed.
Security architecture risk: Minimal · up to f5681
The change strengthens release eligibility checks without expanding publication privileges. Inspection found no introduced or worsened security, artifact-identity, or failure-containment issue. Live release execution was not validated.
Retained concerns
No architecture-level concerns identified.
Security review details
Security Blast Radius
inferred — The changed control governs eligibility to upload repository release assets and publish cuda-python distributions to TestPyPI and PyPI. It does not introduce a new publication destination or increase the permissions assigned to those publication jobs.
Trust Boundaries and Controls
observed — The new job installs externally published dependencies without configured GitHub token permissions or a source checkout. Release writes and package-publishing identity tokens remain confined to separate jobs; the package jobs retain their named TestPyPI and PyPI environments.
inferred — The first-wheel installation does not establish a validation bypass: the upstream validator restricts cuda-python to its expected universal wheel target and rejects duplicate or unexpected targets before the shared artifact is created.
Resilience and Maintainability Implications
inferred — Failed, skipped, or cancelled dependency validation cannot satisfy the explicit cuda-python success conditions before upload or TestPyPI publication. Per-component release serialization remains in place. The existing clobbering asset upload is not made transactional by this change; partial-upload recovery remains an unchanged limitation rather than a newly introduced concern.
- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Reviewing files that changed from the base of the PR and between ba7dcd0 and f5681ad.
Files selected for processing: 2
.github/RELEASE-bindings.md
.github/workflows/release.yml
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.
closesNVIDIA#2342
PR NVIDIA#2334 disabled metapackage dependency resolution in artifact-based CI
to unblock subpackage releases. Restore this coverage for cuda-python
releases by installing the candidate wheel with published PyPI dependencies
in clean environments.
Test default and [all] installs across the tagged source's supported Python
versions, including free-threaded builds, on Linux x86-64, Linux ARM64,
and Windows x86-64. Require binary wheels and run pip check.
Run validation during dry runs and full releases, and require success
before asset uploads or package publication. Document that dependencies
must reach PyPI before validating the metapackage release.
Validation: workflow/YAML/SPDX/format checks, nine pip scenarios, and
208 release-gating scenarios passed. CI-tool suite: 392 passed; one
sandbox UID/signing failure. Full pre-commit stopped on a link-checker
download failure. GitHub release dry runs were not executed.
Preview will be ready when the GitHub Pages deployment is complete.
This branch has not been deployed
No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closes #2342
PR #2334 disabled metapackage dependency resolution in artifact-based CI to unblock subpackage releases. Restore this coverage for cuda-python releases by installing the candidate wheel with published PyPI dependencies in clean environments.
Test default and [all] installs across the tagged source's supported Python versions, including free-threaded builds, on Linux x86-64, Linux ARM64, and Windows x86-64. Require binary wheels and run pip check.
Run validation during dry runs and full releases, and require success before asset uploads or package publication. Document that dependencies must reach PyPI before validating the metapackage release.
Validation: workflow/YAML/SPDX/format checks, nine pip scenarios, and 208 release-gating scenarios passed. CI-tool suite: 392 passed; one sandbox UID/signing failure. Full pre-commit stopped on a link-checker download failure. GitHub release dry runs were not executed.
Checklist