Skip to content

[no-ci] Limit NVSkills CI to NVIDIA/cuda-python - #3491

Merged
rwgk merged 2 commits into
mainfrom
rwgk/nvskills-ci-repository-guard
Nov 18, 2026
Merged

rwgk merged 2 commits into
mainfrom
rwgk/nvskills-ci-repository-guard

Conversation

@rwgk

@rwgk rwgk commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

— codex on behalf of Ralf —

Description

Copies of this workflow in other repositories can require NVSkills validation statuses even when that integration is not configured there.

Restrict the request job to github.repository == 'NVIDIA/cuda-python' for all existing event paths: pull requests, /nvskills-ci comments, and signature-bot pushes. Pull requests from forks targeting NVIDIA/cuda-python retain their existing behavior.

Validation

Full pre-commit run --all-files, including actionlint, and local repository/event condition checks.

Checklist

  • I have read the Contributing Guidelines.
  • Local condition checks cover the changed workflow behavior.
  • No documentation changes are needed.

rwgk added 2 commits November 18, 2026 11:46
Apply the repository guard to every existing event path. Copies of the workflow in other repositories skip the integration, while fork pull requests targeting NVIDIA/cuda-python retain the current behavior.
@copy-pr-bot

copy-pr-bot Bot commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions Bot added the CI/CD CI/CD infrastructure label Nov 18, 2026
@rwgk rwgk added this to the CI milestone Nov 18, 2026
@rwgk rwgk self-assigned this Nov 18, 2026
@coderabbitai

coderabbitai Bot commented Nov 18, 2026

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Summary

Summary by CodeRabbit

  • Chores
    • Automated NVSkills CI requests are now limited to the NVIDIA/cuda-python repository. Existing pull request, issue comment, and signed push triggers remain in place within that repository.
  • User Impact
    • No changes to app functionality or user-facing behavior.

The NVSkills CI request job now checks that the repository is NVIDIA/cuda-python before evaluating its existing pull-request, issue-comment, and signature-push conditions.

Changes: NVSkills CI request gate

Layer / File(s) Summary
Repository eligibility gate
.github/workflows/request-nvskills-ci.yml
The request job requires the repository to be NVIDIA/cuda-python before evaluating the existing request conditions.

Suggested reviewers: danielfrg

Change: Bug fix

Merge Risk: Minimal · up to 4bfcf

This restricts the NVSkills CI request job to the NVIDIA/cuda-python repository, so copies of the workflow in other repositories skip it. Fork pull requests against the upstream repository are unaffected. No merge-blocking risk was identified.

Architecture risk: Low · up to 4bfcf

The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency.

Changed systems: None identified.

Architecture concerns
No architecture-level concerns identified.

Review details

Before / after behavior

  • observed — Modified behavior in .github/workflows/request-nvskills-ci.yml: The request job now requires the repository to be NVIDIA/cuda-python before accepting the existing pull-request, matching issue-comment, or configured signature-push conditions.
- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 0f4983b and 4bfcf68.

Files selected for processing: 1

  • .github/workflows/request-nvskills-ci.yml

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

@rwgk rwgk changed the title Limit NVSkills CI to NVIDIA/cuda-python [no-ci] Limit NVSkills CI to NVIDIA/cuda-python Nov 18, 2026
@rwgk
rwgk requested a review from jpascucci-nv November 18, 2026 19:59
@rwgk

rwgk commented Nov 18, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 4bfcf68

@rwgk
rwgk enabled auto-merge (squash) November 18, 2026 20:05
@rwgk
rwgk merged commit 9eef4b7 into main Nov 18, 2026
33 of 34 checks passed
@rwgk
rwgk deleted the rwgk/nvskills-ci-repository-guard branch November 18, 2026 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD CI/CD infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants