You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
No actionable comments were generated in the recent review.
Summary
Summary by CodeRabbit
Tests
Expanded coverage of CUDA graph, kernel-launch, event, linker, module, and texture operations using both legacy and current pinned-memory resources.
Added coverage for launching a kernel with pinned host output on a green context.
Updated existing tests to exercise pinned-memory allocations across more scenarios.
Changes
The test suite now supplies pinned-memory allocators for legacy and current pinned resources. Graph and direct kernel tests use these allocators for buffers, and graph lifetime tests also cover device memory.
Pinned memory kernel test coverage
Layer / File(s)
Summary
Shared allocator and test helpers cuda_core/tests/conftest.py, cuda_core/tests/helpers/memory.py, cuda_core/tests/helpers/latch.py, cuda_core/tests/test_helpers.py, cuda_core/tests/test_event.py, cuda_core/tests/memory_ipc/test_event_ipc.py
A parametrized fixture provides allocators for both pinned resource types. LatchKernel receives the allocator, as do its event and IPC test callers.
Graph kernel tests cuda_core/tests/graph/*
Graph capture, conditional, mutation, update, node-update, and lifetime tests allocate buffers through the shared allocator. Lifetime tests cover device memory and both pinned resource types.
Direct kernel launch tests cuda_core/tests/test_launcher.py, cuda_core/tests/test_linker.py, cuda_core/tests/test_module.py, cuda_core/tests/test_green_context.py, cuda_core/tests/test_texture_surface.py
Kernel launch tests use pinned buffers for inputs or outputs. Launcher resource cases include both pinned resource types.
Assessment against linked issues
Objective
Addressed
Explanation
Run kernel tests using both LegacyPinnedMemoryResource and PinnedMemoryResource buffers [#3414]
✅
Possibly related issues
NVIDIA/cuda-python#3472: The PR adds kernel tests that use PinnedMemoryResource, but does not address the Windows host-pool allocation failure.
NVIDIA/cuda-python#3415: The tests exercise kernels with PinnedMemoryResource buffers, but do not change or test device-access grants across devices.
Suggested reviewers:andy-jost, juenglin
Change: Other · Severity of issue fixed: Medium
Merge Risk: Minimal · up to b7a63
This change broadens kernel test coverage to buffers from both pinned memory resource types. It does not change library behavior. No concrete merge-blocking risk was identified, and ordinary CI on CUDA hardware should confirm the new cases.
Security architecture risk: Minimal · up to b7a63
The changes expand pinned-memory test coverage without an established change to production exposure, privileges, or ownership guarantees.
- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.
Preview will be ready when the GitHub Pages deployment is complete.
This branch has not been deployed
No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuda.coreEverything related to the cuda.core moduletestImprovements or additions to tests
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closes #3414
Expand existing tests to use PinnedMemoryResource too
Checklist