Repository navigation
Conversation
|
/ok to test adeb29a |
|
No actionable comments were generated in the recent review. Summary
Change: Other Merge Risk:
|
|
juenglin
left a comment
There was a problem hiding this comment.
Approving to keep this aligned with NVIDIA-dev/cuda-python-private#885 and off the critical path. Could we track a follow-up that replaces the per-platform Cython test wrappers in all three roots (cuda_core, cuda_bindings_12, cuda_bindings_13) with a single cross-platform step?
The wrappers exist only to pass include directories to the compiler (CPLUS_INCLUDE_PATH on Linux, CL or INCLUDE on Windows). Each root's build_tests.py already loads _build_shared.py, so it can add the directories itself:
cuda_include_dir = Path(build_shared._get_cuda_path()) / "include"
for extension in ext_modules:
extension.include_dirs += [str(core_include_dir), str(cuda_include_dir)] # bindings: cuda_include_dir only
extension.extra_compile_args.append("/std:c++17" if os.name == "nt" else "-std=c++17")_get_cuda_path() resolves CUDA_PATH or CUDA_HOME the same way the package build does and raises if neither is set.
Then:
build-wheel.yml: replace the platform-specific steps for Core and bindings, both variants, with one step each:working-directory: <root>/tests/cython,run: python build_tests.py.- Each
pixi.toml: merge thelinuxandwin-64build-cython-teststasks into one task runningpython $PIXI_PROJECT_ROOT/tests/cython/build_tests.py. - Wrappers: delete
build_tests.shandbuild_tests.batin all three roots, or reduce them to pass-throughs. Update theAGENTS.mdand README references. - Behavior change to decide: on Linux,
CPLUS_INCLUDE_PATHcurrently gives these headers system-header warning suppression, andinclude_dirs(-I) does not. Either accept the extra warnings or pass these directories as-isystem.
— codex on behalf of Ralf —
Description
Add a native batch wrapper for building the cuda.core Cython tests. It supplies the Core and CUDA toolkit header directories to MSVC and delegates to the existing Python builder. The Windows Pixi task already points to this wrapper.
Run the batch wrapper in the Windows wheel build for both the current and maintenance CUDA variants. The wheel jobs upload the resulting extensions for the existing GPU test jobs. Linux builds continue through the shell wrapper.
xref: ctk-next 885
Checklist