Repository navigation
Conversation
Flush() previously truncated the spec file with os.Create before writing, so a failed write (disk full, I/O error) permanently destroyed the container's config.json and left the container unable to start. Write the spec to a temporary file in the same directory, sync it, preserve the original file mode, and atomically rename it into place. A failed write now leaves the existing file intact. Adds regression tests covering the success path (contents, mode, no leftover temp files), the failure path (existing file preserved), and flushing without a loaded spec. Fixes NVIDIA#2203 Signed-off-by: Vibe Nuage Agent <vibe@mistral.ai> Co-authored-by: ardatas <ardatas@users.noreply.github.com>
ardatas
requested review from
cdesiniotis,
henry118 and
tariq1890
as code owners
November 13, 2026 00:39
The spec file tests deliberately create files with mode 0644 to verify that Flush preserves the original permissions; gosec G306 flags these writes, so annotate them like the existing ldconfig tests do. Signed-off-by: Vibe Nuage Agent <vibe@mistral.ai> Co-authored-by: ardatas <ardatas@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flush() previously truncated the spec file with os.Create before writing, so a failed write (disk full, I/O error) permanently destroyed the container's config.json and left the container unable to start.
Write the spec to a temporary file in the same directory, sync it, preserve the original file mode, and atomically rename it into place. A failed write now leaves the existing file intact.
Adds regression tests covering the success path (contents, mode, no leftover temp files), the failure path (existing file preserved), and flushing without a loaded spec.
Fixes #2203
Issue
Fixes #
Description
Checklist
make test)make lint)Testing