Repository navigation
fix(config): require non-empty absolute paths for ldconfig - #2225
Open
b1scu1td3stroy3r wants to merge 1 commit into
Open
b1scu1td3stroy3r wants to merge 1 commit into
b1scu1td3stroy3r wants to merge 1 commit into
Conversation
Signed-off-by: b1scu1td3stroy3r <terrywhite2025@gmail.com>
b1scu1td3stroy3r
requested review from
cdesiniotis,
henry118 and
tariq1890
as code owners
November 15, 2026 15:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
N/A — proactive config validation hardening for
nvidia-container-cli.ldconfig.Description
Tightens
ldconfigPath.assertValid()inapi/config/v1to reject empty or relative paths:nvidia-container-cli.ldconfigvalues ("").@<path>) to specify an absolute path after the@prefix, rejecting bare"@"and relative paths such as"@sbin/ldconfig".features.allow-ldconfig-from-container = true) to specify an absolute path starting with/.Checklist
make test)make lint)Testing
Added table-driven unit test cases in
TestAssertValid(api/config/v1/config_test.go) covering empty, bare@, non-absolute host, and non-absolute containerldconfigvalues. Relying on GitHub Actions CI for Linuxmake testandmake lintverification.