Repository navigation
Develop - #239
Merged
Merged
Develop#239
Conversation
…in, there are no multiple sessionuuids
…/constdb summary (dbsummary.sql) counted rows of ap.querytable rather than distinct sites and datasets, and read from that cache table. For NODE (databaseid 41) this gave 810,714 rows for 4,224 datasets, so the landing page showed e.g. 666,024 surface samples instead of ~4,135 datasets / 3,920 sites. Two causes: - COUNT(siteid) / COUNT(*) replaced COUNT(DISTINCT ...) in f6264de. - ap.querytable is upserted on (datasetid, chronologyid) and never pruned, so it keeps rows for deleted datasets, datasets removed from a database, and superseded chronologies.
Hotfix/taxa crash and Summary bug that Alison reported
and several also carried an unrelated generic (for example Must pass either queries or a comma separated integer sequence. on a
SQL failure). They now send { status: 'failure', data: null, message: <error text> } which is the shape taxonquery already uses after the taxa crash fix.
Responses that carried extra fields ( in occurrence.js) keep them.
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
The checks job now also runs on pushes to develop and production. It is renamed from pr-checks to checks since it is no longer PR-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements to the test workflow, error handling, and test coverage for the Neotoma API. The main changes include enhancements to the GitHub Actions workflow for more accurate environment targeting and dependency management, improved error logging in the application, and updates to test queries and test data for better coverage and reliability.
CI/CD Workflow Improvements:
.github/workflows/test.yml) now dynamically targets either thedevorproductionserver based on the triggering branch, ensuring tests run against the correct environment. It also checks out the exact commit that was deployed, enables Corepack for Yarn 4 compatibility, updates Node.js to version 22 to match the Dockerfile, and switches toyarn install --immutablefor stricter dependency management. [1] [2]Error Handling Enhancements:
app.js) now logs the reason for unhandled promise rejections and uncaught exceptions before exiting, aiding in debugging and observability.Test and Build Script Improvements:
package.jsonscript for starting the app now uses--exitcrashwith nodemon for better crash handling, and a newtest:unitscript is added for running unit tests.openapi/scripts/build-openapi.js) now gracefully handles missing directories, preventing errors during fresh checkouts.Test Data Updates: