Skip to content

Dev apicalls - #75

Merged
sedv8808 merged 5 commits into
devfrom
dev-apicalls
Oct 22, 2026
Merged

sedv8808 merged 5 commits into
devfrom
dev-apicalls

Conversation

@sedv8808

Copy link
Copy Markdown
Collaborator

This pull request introduces several improvements and maintenance updates to the neotoma2 R package. The most significant changes are enhancements to the S4 class definitions for consistency and readability, updates to HTTP request handling and caching, and the addition of new configuration and linting settings. The NEWS file has also been updated to reflect recent changes and improvements to package behavior.

S4 Class Definitions Modernization:

HTTP Request Handling and Caching Improvements:

  • Updated the default request timeout to 125 seconds to better align with API gateway limits, improved retry logic for various HTTP error codes, and enhanced client identification via the User-Agent header. Added caching for get_table() and batched requests for get_downloads() and other endpoints. These changes aim to make the package more robust and gentler on the Neotoma API.
  • Improved handling of long lists and POST/GET requests, fixed issues with malformed dataset ID lists, and clarified error reporting for failed or malformed responses.
  • Updated the documentation in NEWS.md to reflect all these changes and removed outdated references to the previous timeout value.

Configuration and Linting:

  • Added a .lintr configuration file to specify exclusions and custom linter settings for specific files, helping maintain code quality while accommodating legacy or auto-generated code.
  • Updated .Rbuildignore to ignore the .lintr file, preventing it from being included in package builds.

Namespace and Dependency Updates:

  • Added httr::config to the NAMESPACE imports to support new HTTP configuration options.
  • Removed unused str_extract_all import from stringr in NAMESPACE to clean up dependencies.

Copilot AI balanced review requested due to automatic review settings October 22, 2026 15:32

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@sedv8808
sedv8808 merged commit f1e922c into dev Oct 22, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants