Skip to content

CSTACKEX-361: ONTAP NFS volume created from snapshot loses its path and cannot be attached to a VM #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sp16743 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

CSTACKEX-361: ONTAP NFS volume created from snapshot loses its path and cannot be attached to a VM #132

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...n/src/main/java/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1787,7 +1787,11 @@ else if (HypervisorType.KVM.equals(snapshotInfo.getHypervisorType())) {
VolumeObjectTO newVolume = new VolumeObjectTO();

newVolume.setSize(volumeInfo.getSize());
newVolume.setPath(volumeInfo.get_iScsiName());
String path = volumeInfo.get_iScsiName();

@rajiv-jain-netapp rajiv-jain-netapp Oct 26, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be applicable for the storage vendors, can you check in case of any regressions ?

@sp16743 sp16743 Nov 2, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If iScsiName is available, it continues to be used as the volume path. Otherwise,It falls back to getPath(). If neither value is available, the path remains null. Therefore, existing storage vendors providing iScsiName will not be affected.

if (path == null) {
path = volumeInfo.getPath();
}
newVolume.setPath(path);
newVolume.setFormat(volumeInfo.getFormat());

copyCmdAnswer = new CopyCmdAnswer(newVolume);
Expand Down
Loading