Repository navigation
Fix Excel global dispatch bugs - #523
Merged
jozefizso merged 3 commits intoOct 17, 2026
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Oct 17, 2026
jozefizso
changed the title
jozefizso
changed the base branch from
releases/netoffice_v1.9.11
to
releases/netoffice_v1.9.12
October 17, 2026 21:12
DDERequest currently executes Selection, and the 31-argument _Run2 overload executes Run. Correct only these member names so callers reach the requested Excel APIs without changing signatures or argument order. Add Office-free regressions exercising public wrappers through the real reflection invocation path, including the neighboring _Run2 overload. Patch the maintained release wrappers manually because the imported method definitions are already correct and mass regeneration would introduce unrelated output. Refs #522, #521
jozefizso
force-pushed
the
bugfix/v1.9-excel-global-dispatch
branch
from
October 17, 2026 21:13
987a0f8 to
e3cfdeb
Compare
jozefizso
force-pushed
the
bugfix/v1.9-excel-global-dispatch
branch
from
October 17, 2026 21:14
e3cfdeb to
b073a1f
Compare
jozefizso
added a commit
that referenced
this pull request
Oct 17, 2026
- Correct only the two dispatch strings in `Source/Excel/Modules/Global.cs`; signatures, argument order, attributes and neighboring overloads remain unchanged. - Add Office-free regression coverage for DDERequest, the 31-argument _Run2 overload and its 30-argument neighbor using the actual public wrappers and NetOffice invocation path. - Prepare v1.9.12 through the existing shared release property and changelog. Fixes #522. Fixes #521.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Two Excel global wrappers in the v1.9 maintenance line dispatch to different COM member names than their public APIs promise. This can execute Selection instead of DDERequest, or Run instead of the maximum-arity _Run2.
Changes
Source/Excel/Modules/Global.cs; signatures, argument order, attributes and neighboring overloads remain unchanged.The release wrappers are patched manually because the imported method definitions are already correct. No generator change or mass regeneration is needed. The separate generator compatibility baseline remains unchanged.
Verification
No Office applications were launched. No release tag, GitHub release or package publication has been performed. Validation logs are retained locally in
artifacts/netoffice-v1.9-validation.Fixes #522.
Fixes #521.