Skip to content

Release binary jobs no longer race each other or publish stray artifacts #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MelbourneDeveloper merged 1 commit into from
Oct 13, 2026
Merged

Release binary jobs no longer race each other or publish stray artifacts #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/release-binary-multiplatform.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,11 @@ jobs:
file: ${{ steps.pkg.outputs.archive }}
format: cyclonedx-json
output-file: ${{ steps.pkg.outputs.archive }}.cdx.json
# The publish job attaches every SBOM in dist/. Attaching here races it: once
# the release exists, this read-only job fails trying to replace the asset.
upload-release-assets: false
# The archive's SBOM ships in this job's own artifact below.
upload-artifact: false
- name: Attest build provenance
uses: actions/attest-build-provenance@977bb373ede98d70efdf65b84cb5f73e068dcc2a # v3.0.0
with:
Expand All @@ -127,6 +132,9 @@ jobs:
steps:
- uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6.0.0
with:
# Only this workflow's binaries: an unfiltered download pulls every artifact in
# the calling release run (Deslop reports, the other binary family) into dist/.
pattern: ${{ inputs.binary_name }}-*
path: dist
merge-multiple: true
- name: Generate SHA256SUMS
Expand Down
8 changes: 8 additions & 0 deletions .github/workflows/release-dotnet-aot-multiplatform.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,11 @@ jobs:
file: ${{ steps.pkg.outputs.archive }}
format: cyclonedx-json
output-file: ${{ steps.pkg.outputs.archive }}.cdx.json
# The publish job attaches every SBOM in dist/. Attaching here races it: once
# the release exists, this read-only job fails trying to replace the asset.
upload-release-assets: false
# The archive's SBOM ships in this job's own artifact below.
upload-artifact: false
- name: Attest build provenance
uses: actions/attest-build-provenance@977bb373ede98d70efdf65b84cb5f73e068dcc2a # v3.0.0
with:
Expand All @@ -168,6 +173,9 @@ jobs:
steps:
- uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6.0.0
with:
# Only this workflow's binaries: an unfiltered download pulls every artifact in
# the calling release run (Deslop reports, the other binary family) into dist/.
pattern: ${{ inputs.binary_name }}-*
path: dist
merge-multiple: true
# Own signed checksum file (separate from the Rust binary's SHA256SUMS) so
Expand Down
Loading