[FIX] queue_job: validate JobSerialized base_type again - #985
Open
HoloborodkoBohdan wants to merge 1 commit into
Open
HoloborodkoBohdan wants to merge 1 commit into
HoloborodkoBohdan wants to merge 1 commit into
Conversation
Odoo 19 renamed Field._setup_attrs to _setup_attrs__, so the override was no longer called and an unsupported base_type was silently accepted.
|
All commit authors signed the Contributor License Agreement. |
Contributor
Jordi-Buitrago
approved these changes
Sep 15, 2026
Jordi-Buitrago
left a comment
Jordi-Buitrago
left a comment
There was a problem hiding this comment.
LGTM!
The fix looks correct and the regression test covers the issue.
Tested locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Odoo 19 renamed
Field._setup_attrsto_setup_attrs__(odoo/orm/fields.py), and the old name has no remaining reference in core.JobSerializedstill overrode_setup_attrs, so the override was never called and an unsupportedbase_typewas silently accepted instead of raisingValueError.This renames the override and adds a test:
base_type=dictsets up fine,base_type=intraises. The test fails on the current 19.0 branch.All
JobSerializedfields in the repository usedict,tupleormodels.BaseModel, so re-enabling the check does not affect existing fields.