Repository navigation
Fix double km-to-AU conversion in geo_to_ssbary - #21
Merged
Merged
Conversation
…ssbary. Fixes OSSOS#19. Co-authored-by: Cursor <cursoragent@cursor.com>
ijiraq
force-pushed
the
cursor/fix-geo-to-ssbary-units
branch
from
October 6, 2026 02:32
7596dbc to
ca48079
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19.
geo_to_ssbarydivided the observer's geocentric offset (km) byR1.AU(km/AU) twice, shrinking it by ~1.5e8. Any observation supplied with an explicit observer position (MPC two-line satellite records such as HST, or the Simon Porter format) was therefore fit as if taken from the geocenter.Validation:
test_geocentric_location_matches_obscode: fittingo3o08with Mauna Kea supplied as GCRS x/y/z (km, from astropy) now reproduces the obscode-568 fit (Δa = 5e-5 AU); before the fix Δa = 0.019 AU.hst.mpc(2020 KQ11, 36 min HST arc): fit goes from a retrograde i=166°, d=21.8 AU to i=3.08°, d=54.3 AU. JPL gives i=3.32° and Δ=48.5 AU. The test now also checks inclination.simon_format.txt(2013 LU35) a shifts 43.80 → 43.69 AU; expected value updated.Made with Cursor