Repository navigation
default.xml: Fetch from GitHub over https, push over ssh - #12
Closed
lucianogdittgen wants to merge 2 commits into
Closed
lucianogdittgen wants to merge 2 commits into
lucianogdittgen wants to merge 2 commits into
Conversation
Fetching over ssh needs a GitHub key, so anonymous users could not repo sync these public projects. A pushurl keeps pushes on ssh, as bb064da intended. Tested: anonymous repo init and sync of the manifest. Signed-off-by: Luciano Dittgen <luciano.dittgen@ossystems.com.br>
The ssh URL needs a GitHub key, so anonymous users failed at repo init. Signed-off-by: Luciano Dittgen <luciano.dittgen@ossystems.com.br>
Author
|
Opened by mistake; held until the layer PRs merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fetching over ssh needs a GitHub key, so anonymous users could not
repo init/repo syncthese public projects. Fetch now uses https, and apushurlkeeps pushes on ssh, as bb064da intended. The README'srepo initexample uses https too.Tested: anonymous (
GIT_SSH_COMMAND=false)repo initfrom this branch, then a sync of the projects.remote.github.urlis https and the pushurl is ssh.Merge last, after the layer PRs.
Layer PRs in this release update
The manifest tracks
master, so the merged layer changes need no manifest change. Draft until the open layer PRs merge.