Repository navigation
test: rename CloseAllModulesTestIT so failsafe runs it (#953) - #993
Merged
Merged
Conversation
maven-failsafe-plugin excludes **/*Test* to keep unit tests out of the integration-test phase. That pattern also matched CloseAllModulesTestIT, so its 3 tests had never run since the class moved to src/it in 2019. Rename it to CloseAllModulesIT, like every other integration test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused rename resolves the exclusion mismatch, keeps class references consistent, and introduces no identified issues.
No open issues 🎉
What changed in this PR
Resolves #953 by renaming the integration test class so Maven Failsafe no longer excludes it through the **/*Test* pattern.
Changes:
- Renames
CloseAllModulesTestITtoCloseAllModulesIT, enabling discovery of its three existing tests. - Updates the logger’s class reference without changing test behavior or Failsafe configuration.
| File | Description |
|---|---|
src/it/java/servlets/admin/moduleManagement/CloseAllModulesIT.java |
Renames the test class and updates its logger reference to restore integration-test discovery. |
Review effort: Balanced
SeanDuggan
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #953.
What
maven-failsafe-pluginexcludes**/*Test*to keep unit tests out of the integration-test phase. That pattern also matchedCloseAllModulesTestIT, so its 3 tests have never run since the class moved tosrc/itin 2019.The class is renamed to
CloseAllModulesIT, like every other integration test. Nothing else changes. I renamed it rather than narrowing the exclude, so the exclude keeps covering any unit test that ends up undersrc/it.Tests
The full local pipeline now runs it, and all 3 tests pass:
Every step of
test.ymlpassed locally (lint, build, PGP check, compose build, Tomcat config check, unit tests, integration tests).🤖 Generated with Claude Code