[OisinKyne]

LCDVN and dv-pod now mask .charon/validator_keys from the charon container. If that directory doesn't exist yet, the container runtime creates it as a mount point, often owned by root. A later charon dkg then refuses with "data directory not clean", even though the directory is empty.

checkClearDataDir now removes an empty validator_keys directory and carries on. checkWrites then creates a fresh one owned by the DKG user. A validator_keys directory with any entry, or a validator_keys file, is still refused.

If the removal fails, the error says to remove the directory manually and retry.

Removing a root-owned empty directory works without root, because only write access to the parent .charon is needed. The DKG runs in its own container, where the directory isn't a mount point.

Testing

• TestCheckClearDataDir:
  • a non-empty validator_keys directory is still refused;
  • an empty one passes and is removed.
• go test ./dkg/... -short

category: misc
ticket: none

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[codecov]

Codecov Report

❌ Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.78%. Comparing base (0483b7f) to head (9d72650).

Files with missing lines	Patch %	Lines
dkg/disk.go	76.92%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4834      +/-   ##
==========================================
+ Coverage   67.73%   67.78%   +0.04%     
==========================================
  Files         255      255              
  Lines       33749    33762      +13     
==========================================
+ Hits        22860    22885      +25     
+ Misses      10888    10876      -12     
  Partials        1        1              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.