Repository navigation
macOS look and feel for the desktop shell and apps - #560
Merged
Merged
Conversation
The macOS desktop style, gated on the Mac style everywhere. Other desktop styles and the phone look and behave as before. - Shell: Mac menu bar and app menus (mac_menus.rs), title bars, sheets and alerts for approvals (approvals/mac_kit.rs, mac_view.rs), Dock, glance panel, launcher, Recent Items, sounds, appearance. - Script apps (Mail, Calendar, Maps, Photos, News, Quick Deck, PDF Tools, Writer, Settings, AI Providers, YouTube, Wasm Lab): Mac toolbars, menus, sheets and Undo, with one icon family from apps/interface-icons (tools/sync-app-interface.py copies it into each bundle). - Calendar service: restore_event, so Undo puts a deleted event back with its id and its Glance card. - Makepad changes ride in tools/runtime-patches/makepad-macos-look.patch and makepad-macos-look-2.patch (lock tree b796b0f0): Mac text menus, menu section headings, label_align in one-line fields, signed ramps in Maps' route steps, and the native apps' Mac styles. - Journeys and tests under tools/app-ux and the apps' tests. This is a checkpoint. It includes in-progress edits from two fix agents (the Quick Deck, PDF Tools, Writer, Settings and AI Providers bundles, and crates/shell/src). The tree as a whole has not been built or tested at this commit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- AI Providers on a Mac: the picked row is the accent with white words while the list has the keyboard, and grey under a sheet or alert, as a Mac's table out of focus. - PDF Tools: the tabs and the + answer as soon as a sheet closes. A click on a tab right after a sheet closed used to do nothing. - Quick Deck: the tab bar's + answers a click right after another one. - Quick Deck and PDF Tools: the temporary diagnostic logging that the checkpoint carried is gone. Every app here passed all its journeys in light and dark on the final runs, with no script errors. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…der host sheets On a Mac: - The Web Clients sheet's Advanced section says "Clients on this Mac reach your assistant on port N; other computers can't. A terminal client finds it by itself." It no longer shows the loopback addresses and the WebSocket path. client_info answers the port for this. - While one of the host's sheets is up (Add, Details, the two QR sheets, Web Clients), the list is out of focus, as under the app's own sheets: the picked row is grey and the rows take no clicks. The service answers every sheet request when its sheet closes, so the list comes back. Other desktop styles and the phone are as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Format > Quote Level's Increase is Command-' and Decrease is Option-Command-', as in Mail. The Mac menu parser now knows the apostrophe key, so a row can name it. Mac style only; other styles and the phone are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
On a Mac's desk, Quick Look shows a picture, a PDF or a picture sample of the Files demo in a floating panel. The panel has a close mark and a full-screen mark where a window's lights are, centres the file's name over what it is, and leaves the keyboard with the window under it. A hidden panel keeps its frame until its tile goes, so it no longer paints over the window its Open With opened. The PDF and image viewers' toolbars follow Preview's. Photos' right-click menu gathers the albums under one Add to submenu, as its menu bar does: a script app's gesture menu row can now open a submenu beside it. The makepad changes ride in makepad-macos-look-2.patch, recut from the live tree; the stack replays to it and setup.py --check --cargo passes. Checkpoint of the fix agent's work while its last run is still going: the run before it passed Files 60/60 and Image 34/34 in light and dark with no script errors, and the shell's preview, desk and photos tests; it failed one PDF journey in each appearance, and the PDF light run since passes 17/17. Mac style only; other styles and the phone are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
When a Mac's slideshow can't go full screen (the shell asks for a recent click first), it plays in the window over the photo. Each update of the viewer then asked for the keyboard for the hidden photo as well as for the show, and the photo's ask landed last, so Escape went to the photo: it ended the show and closed the photo too. The photo no longer asks for the keys while a show is up or opening, and a key that still reaches the photo under a show is handed to the show. GestureView's two submenu tests: a map row right after "-" needs a comma, or Splash reads the pair as one value. Proof (fix agent, mini5): photos2 92/92 in light and dark with no script errors, the keys journey included; makepad-widgets 342 of 345, the three failures the same on a clean tree. makepad change recut into makepad-macos-look-2.patch; setup.py --check --cargo passes. Mac style only; other styles and the phone are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
In the shell's Mac style PDF Tools now works as Preview does, and the test still drove the old window: - the library's button says Import…; - Read mode is View's row, and the toolbar ends with the search field; - the tab strip's + and Combine's Add Files… are the Open sheet, where a press picks a PDF and Open or Add takes it; - the status line has no Saved or Edited; the title says "— Edited". The test now takes each path where the window offers it. Other styles and the card host, which doesn't set the theme's ui_unified, keep theirs. With this the shared pdf tools journey passes on the round's final binaries: shell (light and dark), restart, fixture and states. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Fixes after the round-10 independent reviews (cards A7 to F7). Every change is gated on the Mac style; other desktop styles and the phone are unchanged. Shell: - the quit report reads as a Mac's: the termination reason on top and only what went wrong under Problem Details; - a card window's default button is the accent push button; - Spotlight heads a lone result Top Hit; - Terminal's menu rows: App Settings…, Edit Title, Clear to Start, Split Pane, Scroll to Top and Bottom, Page Up and Down, text sizes; - the assistant's reply and selection menus end with Speech and Services submenus; - an app's named Undo and Redo replace the shell's rows; - Finder's right-click ring for gesture views; - Quick Look: the panel's full-screen marks tell its viewer, View > Exit Full Screen is the panel's own, a catalog row with --preview opens as the panel and takes its viewer's resize, and the bar names the app that asked for a full-screen panel, or a row panel's viewer when nothing is in front. Script apps: Settings' About page and search; AI Providers' pair sheet and Web Clients; Writer's alerts; PDF Tools' alerts, comment rows with a status pop-up, and a banner over a document's pages in place of the status bar; Quick Deck's ring; YouTube's Video menu; Software Update's window name; Calendar's named Undo; Maps' Try Again; Photos' sidebar and time scale; Mail's Go to Favorite Mailbox. Native apps, in makepad-macos-look-2.patch (recut from the live tree; the stack replays to it and setup.py --check --cargo passes): Clock, Calculator, Notes, Reminders, Weather, Terminal, Sheets and Task; and Files, Finance, AI Chat, Route, Browser, Image Viewer and PDF Viewer: Quick Look full screen and row panels, selection under sheets, the Open sheet's Recents, Computer, path pop-up, search and columns, Safari's Sidebar, Share and tab overview, Preview's floating Inspector. Tests follow the Mac where it changed: PDF Tools' UI test (Combine's button has no status bar under it), Quick Deck's UI test, AI Providers' refresh test. Proof so far: run18's first part, on a build made before the seven apps' last fixes and the row panel's bar name, passes every journey of every other surface (one Clock journey and the shared pdf tools journey passed on a second run on the same binaries; their notes say why), and the 18 shared journeys; the Linux compile check of this tree passes; the seven apps passed 298 of 298 journeys and 397 tests on their fix run. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Shell, Mac style only: - Wi-Fi and Bluetooth status menus with a real switch (hidden test shells only log the toggle); the joined network, Other Networks… and Wi-Fi Settings…. - Window > Move & Resize gains macOS 15's Arrange group. - About OctoSense: darker copyright line; More Info… opens System Settings at General > About. - Spotlight with no results offers Search the Web; Launchpad with no results is an empty page. - Notification Center shows "No Notifications" only when no widget shows; one AI mark for generated text. - Notifications open what they are about: a Calendar event notice opens the event; a Maps notice with a route opens Directions or the place (`<app>.notify` takes an optional `route`). - Widgets come Small, Medium and Large, from the gallery or the widget's own menu (Edit Widgets…, Remove Widget). - Review alerts draw a destructive button's title in red; the Ask panel stays quiet behind the consent alert. - A press on a window's fixed edge focuses the window. Apps: - Task: Disk's and Network's graph title is a pop-up (DropDown gains `caps`), View's process rows. - Updater: the window fits its words in every state. - Terminal: the add-shortcut sheet keeps its buttons under Action unless a note shows. - Notes: the folder group reads "On My Mac". - Browser: a full-height sidebar with the traffic lights; Search Tabs in the tab overview. - Image and PDF: toolbar items stay in place, dimmed, with no document; the sidebar tool is not lit; PDF Find rows read as one run of text; Search With Google for a selection. - Maps: opens a notice's route; with no start chosen the map flies to the destination. Makepad changes ride in tools/runtime-patches/makepad-macos-look-2.patch (recut; the stack replays to the live tree). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- App Hub 38635915 -> 4abef6b5 (OctoSense-App-Hub feat/macos-look, PR #235): the Mac look, in-place installs, the progress ring. - OctosCode 5d0c2a09 -> 094fe850 (octoscode-app feat/macos-look, draft PR #34, on top of the old pin): the Mac look inside OctoSense; octoscode-module gains the optional makepad-wm-api dependency. - The release scan's OctosCode revision follows; none of its 52 listed assets changed. These are the configurations the macOS look was built and tested with. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 12, 2026
…ck, PDF Tools, AI Providers, Settings and YouTube
Fix (every desktop style): round 11 left Writer's desk window empty under Omarchy, Windows and the other non-Mac styles. Its `let DeskRoot` ended in `if ui_unified { save_alert := … }`; Splash drops a top-level `let` whose body ends in a named child inside a skipped `if`. The alert now sits in a plain box. The same shape inside views is wrapped too: Quick Deck's toolbar title (it dropped Fit and the Slides/Sorter segments), Settings' commands switch and PDF Tools' comments menu.
Mac style:
- Writer: a long document name wraps to two lines and then ends in "…"; a failed export is an alert of its own (what failed and why, OK as default, Try Again only where it can help); the format sheet loses its red line.
- Quick Deck: the toolbar title's "— Edited" is never clipped, and a long name truncates before it; a missing engine says so once.
- PDF Tools: narrow windows keep the document's name and fold lower-priority tools into a » menu; refusals carry the caution glyph.
- AI Providers: a failed list is headed by the caution triangle; the empty table keeps its heading and offers Add….
- Settings: pane rows use the sidebar's filled tiles; About lists the name and version with Copy and Software Update….
- YouTube: clearing the search field goes back to where you were before the search, title included, also after a restart.
Checked: journeys light/dark on a Mac: Writer 24/25 and 25/25 (the one miss passed alone twice), PDF Tools 32/32 twice, AI Providers 17/17 twice, Quick Deck 41/41 twice, Settings 11/11 twice, YouTube 13/13 twice; all six in Omarchy, Windows and macOS styles with no script error and a filled window; the Writer, Quick Deck, PDF Tools, Maps and Settings model tests (137) on Linux.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ymote
marked this pull request as ready for review
November 12, 2026 20:58
Every change is in the Mac style; the phone and the other desktop styles behave as before. - Maps: a double-click zooms in one level about the point clicked and no longer drops a pin (Drop Pin stays in the right-click menu, and the empty column says so); with the sidebar shown its button sits beside the traffic lights; a route lists every step in one scroll; the map pop-up holds the map's modes only, and View > Use Dark Map says whether the map is dark. The first zoom no longer flies to the equator (log2/exp2, not the logger). - Mail: the toolbar runs Archive, Delete, Reply, Reply All, Forward, Flag (new) and Search; a tight window folds Search to a magnifier first, then puts a » at the trailing end. Attachments follow the text under a header with their count, size and a Save… menu. A row's menu has Mark and Move To. View > Sort By (Date, Flags, From, Subject, Unread; Ascending, Descending). New Message's From is a pop-up of the account's addresses. The Accounts window casts its shadow. - News: in a two-column window the shown sidebar lies over the list, and the reader keeps the open story. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…rs' selected rows - Settings, commands sheet: on a Mac the disabled Allow button greys its title as the apps' own disabled push buttons do (the ink faded into the page). The typed phrase stays. - Settings, About: `settings.state` gains `runs_on` (macOS's version and the chip, or an Intel Mac's processor, read from sysctl; empty elsewhere), and a Mac's About lists them under the version. No build or commit is shown: the host has none to give. - AI Providers, add-model sheet: on a Mac the chosen provider, model, route, custom model and custom endpoint rows are selected whole, white words on the same row colour as the app's own list, with no checkmark; the separator lines beside the selection are hidden, as a table's are, and the model and route lists inset their rows so the selection stands clear of the frame. Other styles and the phone keep the tint and the checkmark. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
All in makepad-macos-look-2.patch (recut), on the Mac style only; other
styles and the phone are unchanged.
- Calculator: Basic/Scientific is a borderless toolbar item, its well only
under the pointer or while its menu is open, the modes in a pull-down with
the current one ticked. The history's load failure sets Try Again and
Start Over… in a row, each as wide as its title (small push buttons).
- Clock: World Clock picks its columns and dial size from the window: four
cities make one row, five make three and two, with no empty band beside a
dial (world_layout_mac, tested).
- Notes: Aa and Format gain Subheading (Shift-Command-J), Monostyled
(Shift-Command-M), Dashed List (Shift-Command-8) and Block Quote. They are
lines of the note's Markdown ("### ", four spaces, "– ", "> "), read so
only under the Mac style, and survive saving and reopening (tested). The
body's menu starts with Look Up "…" and Search With Google on a selection,
as Terminal's: the system dictionary and the default browser.
- Reminders: a list's menu gains Rename…, Sort By (Manual, Due Date,
Creation Date, Priority, Title; saved per list) and Show/Hide Completed.
Only a sorted list writes its new `sort` key, so files with no sorted list
stay readable by older builds.
- Weather: no + and no Add Location popover. A city is found in the
sidebar's search, shown with Cancel and Add, and only Add saves it;
Command-N and File > Add Location go to that search. In a small window the
sidebar's button brings the sidebar back; the list pull-down is gone.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
960bfa13 is the last commit of octos-org/octoscode-app's macOS look branch before it took in main (#9 to #27). It is on octoscode-app main's history through #34. Inside OctoSense, main's merge changes how a hosted window connects (#27) and breaks the in-place workspace rename and a chat row's right-click menu in the Mac look; those are fixed on octoscode-app first, and the pin moves to that fix afterwards. The release scan's 52 reviewed assets are unchanged at this revision. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Round 12 made `load` and `start` read `ui_unified` (a Mac's pane keeps its list's heading over an empty table, and draws its tools), but the host-service test that runs those functions in a stub scope only declared `ui_desk`, so it failed with "variable ui_unified not found". The test now declares it too, as false: the touch app it covers. The apps job never ran on this branch before #561 moved it to macos-15. Every step of that job passes on macOS 15 with this change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The macOS package job refused the pinned OctosCode's demo workspace paths, `/home/user/src/octoscode-app` and `/home/user/src/octos`. At 960bfa13 the macOS linker pools them before the theme names as it did at 5d0c2a0, but it aligns the names with five NUL bytes, so the proven sequence no longer matched. The seam now allows up to 15 NULs in that gap and nothing else. The tests add that layout and three tampered ones: a non-NUL byte, 16 NULs, and a path in the gap. A macOS build at the same pin no longer has the Linux-home finding. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Windows package job's release scan read "sendoctosense.local" as a
private host name: round 12's cc field changed the literals around
add_attempt(), and the Windows linker now pools the bare fallback
"octosense.local" right after "send", outside the reviewed sequence the
scan admits. The fallback now lives whole in its own format string,
"<{operation}@octosense.local>", so no bare literal is left to glue to
a word. The Message-ID is the same as before.
The Mail service's 67 tests pass.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Windows package still refused the pinned OctosCode's two demo workspace paths. A dry run of the release workflow on a temporary branch printed the bytes around them: the Windows linker puts server_word()'s "This Mac" (chrome.rs 3164) between the second path and the theme names, where the macOS linker leaves NUL padding. The seam's gap now takes either NULs, at most 15, or exactly "This Mac", and nothing else. The tests add the Windows layout and three tampered ones. The scan over the Windows bytes from that dry run finds nothing, and those two spans were its only unproven ones. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The desktop shell and its apps in a macOS look and feel, judged against a 95/100 rubric (
tools/app-ux/macos-rubric.json, scored bytools/app-ux/macos_score.py). Everything is gated on the Mac desktop style. The phone tree and the other desktop styles keep their own trees.This update brings round 12's last app fixes (Calculator, Clock, Notes, Reminders and Weather), pins OctosCode at its macOS look, and takes in main, so the macOS jobs now run on macos-15 (#561). Independent reviewers have graded every surface on the round-12 builds: 14 of 38 reach 95, and 13 more score 94 or above. No surface fails a hard gate.
What it covers
tools/runtime-patches/makepad-macos-look.patchandmakepad-macos-look-2.patch. The stack replays to the live tree, andsetup.py --check --cargopasses.Scores, round 12
The average over all 38 is 94.4. After round 11, 3 of 38 reached 95. Six reviewers graded six groups of surfaces from the rig's grabs in both appearances.
Surfaces at 94 or above got no more work. The defects that cost each surface most are in each reviewer's card.
Tested
All of this ran on Mac minis, on three round-12 builds of this branch. The second build adds the last five apps' fixes. The third differs from the second only in OctosCode, built at 960bfa13.
OctosCode's two misses are one journey, "a chat row's right-click menu", in each appearance. 960bfa13 has no chat-row menu, and neither has the OctosCode that main pins. octos-org/octoscode-app#35 brings it.
cargo check --testsis clean.Behaviour changes worth a look
<app>.notifytakes an optionalroute, up to 256 bytes with no control characters. Maps declaresdirections/…andplace/….settings.stategainsruns_on, read from sysctl on a Mac (macOS version and chip). About lists them.dict://) and Search With Google. Both go through the platform'sopen_url, so Search With Google opens the computer's browser, not the desktop's Browser.sortkey in the list's JSON, only for a list that isn't Manual. A build from before this one refuses a document that has a sorted list.Open decisions for a maintainer
CI
The macOS jobs run on macos-15 since #561. That move ran a test the retired image had kept from running, and it failed: AI Providers' refresh test did not declare the
ui_unifiedflag that round 12's script reads. 4049bed declares it. Every step of the apps job passes with it on a macOS 15 mini, and on 4049bed every check passed except the macOS and Windows packages.Both packages failed their scan for private paths and names, on public literals this branch moved:
/home/user/src/octoscode-app,/home/user/src/octos). At 960bfa13 the macOS linker aligns the theme names after them with five NUL bytes, so the reviewed sequence stopped matching. 75309b0 lets only NULs, at most 15, sit in that gap, with tests for the new layout and three tampered ones. A macOS build at the same pin no longer has the finding.octosense.localright aftersend, which the scan reads as a host. 45adc48 writes the fallback whole in the Message-ID's format string,<{operation}@octosense.local>. The Message-ID is unchanged, and the Mail service's 67 tests pass.On 5d76a76 all 16 checks are done: 13 pass, and the three release steps (draft release, sign-macos, sign-windows) skip on a pull request by design.
Framework issue found
Splash drops a top-level
letwhen anifwithout anelseis skipped and its block ends in a named child or a property. Nothing is logged at that spot. The next use fails with "variable not found", and those errors bypassvm.take_errors().🤖 Generated with Claude Code