Repository navigation
fix(sandbox): a sandbox chat's model and effort behave like any T3 chat - #70
Merged
t3-code-sandboxes[bot] merged 4 commits intoNov 15, 2026
Merged
Conversation
…and keeps its effort Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…es out Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… switches models Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… reported Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2 tasks done
Base automatically changed from
fix/sandbox-mirror-working
to
feat/sandbox-environments
November 15, 2026 21:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #68.
Problem. In a sandbox chat, the model picker and the model and effort it sends didn't behave like a normal T3 chat:
[effort:high]and[effort:high, fastMode:false]counted as different, and a host pick that only omitted options removed them from the sandbox.Fix (sandbox code only; generic composer and provider logic are unchanged).
sandboxMirrorPickerSourcelists exactly the mirror's own model, read-only. Each of the mirror's options becomes a one-choice control, so a send keeps them. Web and mobile both get this through client-runtime.sandboxSelectionForcompares by meaning:modelOptionArrivesLate, as Kiro's does, because the bridge lists the sandbox's models only once the sandbox answers.console.warn. The composer keeps the pick, so the next send carries it.Test plan
sandboxMirror.test.ts: offers only the mirror's own model and options while neither has read the sandbox, and the composer's helpers keep[effort:xhigh, fastMode:true](fails on the base)bridge.test.ts: compares options by meaning and keeps the sandbox's for any the host leaves out (fails on the base)AcpRegistryAdapterV2.test.ts: a bridge session opened with no model option still reportssupportsModelSwitchInSession(fails on the base)check:changed, format, lint, knip and react compiler pass. Its test step fails only the 4remote-parentcases, whose fixture lacksmodelSelection; test: fix the tests that fail on the sandbox branch itself #69 fixes that fixture.Claude Opus 5.5 via Claude Code.
🤖 Generated with Claude Code