Repository navigation
fix(bottom-tabs): report tab bar height on placement change - #209
Merged
Merged
Conversation
The height was only reported on creation and visibility changes, so a bar moving from a vertical strip to the bottom kept its column height. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
originalix
reviewed
Nov 4, 2026
A vertical bar measures its full column height, which the drawer and height hooks consumed as bottom space, rejecting most drawer swipes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
originalix
reviewed
Nov 5, 2026
huhuanming
enabled auto-merge (squash)
November 5, 2026 03:55
With a vertical bar reporting no bottom height, a rightward drag on the bar could open the drawer and interrupt the system tab gesture. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Minnzen
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
onTabBarMeasuredonly fired on creation and when the tab bar was hidden or shown. On iPhone Duo the bar moves between a vertical strip and the bottom as the device rotates or folds, so JS kept the height from the previous placement. A vertical bar reports its full column height (678pt on the outer display), which then applied to the bottom bar.This reports the height again whenever the placement changes, right after
onTabBarPlacementChange, and documents the behaviour indocs/SPEC.md.Verification
Tested on the iPhone Duo simulator (iOS 27.1, Xcode 27.2) by adding the same line to the published
6.7.0-alpha.432package in app-monorepo:The change has not been compiled from this branch; the existing native CI covers that.
Android is unaffected because this is iOS-only code.
🤖 Generated with Claude Code