Repository navigation
feat(intercom): add source SDK for React Native 0.88 - #210
Draft
huhuanming wants to merge 3 commits into
Draft
huhuanming wants to merge 3 commits into
huhuanming wants to merge 3 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a private source-built
@onekeyfe/react-native-intercompackage targeting React Native 0.88 / React 19.3, New Architecture. Preserve the Intercom RN 10.8.1 public API and Android 18.10.0 / iOS 19.9.1 behavior, including cards/sheets, remote Web JavaScript and native bridges.Build and integration
prepackbuilds JavaScript/declarations and unconditionally rebuilds the native sources, then includes exactly two own-source AARs and two POMs in the SDK archive. No checksum sidecars, module/version metadata, build intermediates or receipts enter the package.prepareremains JavaScript/declarations only; no install/postinstall native build is added. POMs preserve the effective original dependency graph (base 138 / UI 65 components).Validation
npm packwith no SDK compiled outputs, plus real Yarn 4.1 packing: both final archives contain 4,988 files, the four generated Maven artifacts and all required source/JS/type inputs. No hidden build/cache/report entries leak into either archive. Protected native/bridge inputs match the baseline; regenerated Maven bytes also match it.assembleDebug, Codegen, C++/JSI linkage, AAPT and duplicate-class checks. Its actual APK contains the native SDK, wrapper and generated module implementation, resolving both own-source Maven components from the installed package.Acceptance boundary
This remains a draft source SDK. Full backend sessions, native UI/cards/sheets/media/push parity, real-device acceptance and private Swift ABI compatibility remain unaccepted. The producer was exercised on macOS; Linux execution remains unverified. Android APK validation is a build check, not a launch/runtime check. Security remediation and security re-auditing are explicitly deferred: clipboard behavior, remote Web JavaScript and bridge behavior remain unchanged, with no safety claim.
Raw imported-source whitespace and semantic empty TSV columns are preserved. The repository has no
agent:checkscript; its actual package and repository checks were used.