Skip to content

fix: stabilize Web recipient row sizing during modal animation (OK-66253) - #211

Merged
limichange merged 1 commit into
mainfrom
codex/ok-66253-web-identity-height
Nov 5, 2026
Merged

limichange merged 1 commit into
mainfrom
codex/ok-66253-web-identity-height

Conversation

@huhuanming

Copy link
Copy Markdown
Contributor

Opening Send from asset details can collapse Recent recipient rows or overflow the stack while the modal scales. Identity rows measured transformed visual bounds and fed that size back into layout.

Use intrinsic body sizing for opt-in auto height, measure the untransformed CSS layout height with offsetHeight, and wrap unspaced multiline subtitles. Explicit heights and single-line behavior remain unchanged, and the modal animation is preserved. This changes only the renderer, its existing parity tests, and SPEC; no dependency or version updates.

Validation:

  • Reproduced collapse and stack overflow in the full production Web app using isolated wallet/API fixtures and a test-page fixture bridge to existing runtime exports (Web single-runtime).
  • With the candidate, three warm reopens kept row/content height at 68px throughout scale 0.95 → 1.00434 → 1. Width changes, menu placement, and recipient input filling passed, with zero page or console errors.
  • A separate 20-recipient API fixture verified two DOM row-wrapper reuses after scrolling and successful selection after returning to the top.
  • Existing focused parity suite: 10/10 passed; regression coverage fails against the original renderer. Package tsc -b, changed-file ESLint, Bob module build, and diff checks passed.

Electron, extension main UI, and native runtime acceptance remain unverified. No transaction was signed or sent. This PR does not publish the SDK or bump the consuming app.

@limichange
limichange enabled auto-merge (squash) November 5, 2026 05:31
@limichange
limichange merged commit 1d46002 into main Nov 5, 2026
15 checks passed
@limichange
limichange deleted the codex/ok-66253-web-identity-height branch November 5, 2026 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants