Skip to content

test(svdconv): expand unit and generator coverage - #2634

Merged
thorstendb-ARM merged 2 commits into
mainfrom
test/svdconv-coverage
Sep 23, 2026
Merged

thorstendb-ARM merged 2 commits into
mainfrom
test/svdconv-coverage

Conversation

@thorstendb-ARM

Copy link
Copy Markdown
Contributor

Changes

  • Add 73 focused tests for model validation, conversions, parsing, memory maps and enum headers.
  • Tests only; no production, workflow or dependency changes.

Validation

  • macOS/Linux: 138 active unit and 42 integration tests pass; shuffled macOS runs pass.
  • Fresh Linux LCOV: lines 57.50% → 69.86%, branches 41.65% → 53.89%. No baseline coverage lost.

Add focused model, conversion, parser and output tests without changing production code or coverage thresholds.
@github-actions

github-actions Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Test Results

  4 files   -    41   32 suites   - 107   7s ⏱️ - 18m 28s
182 tests  - 1 288  182 ✅  - 1 271  0 💤  - 17  0 ❌ ±0 
362 runs   - 3 169  362 ✅  - 3 104  0 💤  - 65  0 ❌ ±0 

Results for commit de2e7c7. ± Comparison against base commit f46d68b.

This pull request removes 1361 and adds 73 tests. Note that renamed tests count towards both.
AuxCmdTests ‑ MkdirCmdTest
AuxCmdTests ‑ RmdirCmdTest
AuxCmdTests ‑ TouchCmdTest
BuildSystemGeneratorTests ‑ GenAuditFile
BuildSystemGeneratorTests ‑ GenAuditFile_WithOut_Existing_Audit_File
BuildSystemGeneratorTests ‑ GenAuditFile_With_Existing_Audit_File
BuildSystemGeneratorTests ‑ GetString
BuildSystemGeneratorTests ‑ StrConv
BuildSystemGeneratorTests ‑ StrNorm
CBuildGCCTests ‑ Asm
…
SvdCExpressionParserTest ‑ HandlesEmptyInputAndTokensAtEndOfInput
SvdCExpressionParserTest ‑ PreservesTokenOrderAndTextInRegisterExpression
SvdCExpressionParserTest ‑ RecognizesOperatorsAndQualifiers
SvdConvEnumHeaderTests ‑ ClusterAndDerivedRegisterEnumsHaveDistinctTypesAndValues
SvdConvEnumHeaderTests ‑ FieldEnumsPreserveValuesWithoutBitOffsetShift
SvdConvIntegTests ‑ ExpandsRegisterAndFieldDimensionsInMemoryMap
SvdConvIntegTests ‑ GeneratesMemoryMapsAtRequestedDetailLevel
SvdCpuModelTest ‑ AcceptsPmuCounterCountsForSupportedCpu
SvdCpuModelTest ‑ BaselineCpuOmitsMainlineFaultHandlers
SvdCpuModelTest ‑ ChecksNvicPriorityWidthBoundaries
…

♻️ This comment has been updated with latest results.

Comment thread tools/svdconv/test/unittests/src/SvdModelValidationTest.cpp Fixed
@codecov

codecov Bot commented Sep 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.68%. Comparing base (f46d68b) to head (de2e7c7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2634      +/-   ##
==========================================
+ Coverage   74.67%   78.68%   +4.00%     
==========================================
  Files         197      197              
  Lines       32778    32778              
  Branches    19152    19152              
==========================================
+ Hits        24478    25790    +1312     
+ Misses       6000     4662    -1338     
- Partials     2300     2326      +26     
Flag Coverage Δ
svdconv-cov 60.31% <ø> (+12.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 29 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@thorstendb-ARM
thorstendb-ARM merged commit 3c16c5c into main Sep 23, 2026
26 checks passed
@thorstendb-ARM
thorstendb-ARM deleted the test/svdconv-coverage branch September 23, 2026 11:11
edriouk pushed a commit that referenced this pull request Sep 23, 2026
## Summary

- Exclude component coverage checks when no fresh flag report was
uploaded for the commit, including carried-forward reports.
- Keep carryforward data, coverage targets, thresholds, and upload
failure handling unchanged.
- Prevent false cross-component regressions such as the SVDConv check in
#2633 after merging #2634.

## Validation

- Official Codecov YAML validator: `Valid!`.
- `git diff --check` passed. Only `codecov.yml` changes; no source or
workflow changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants