Skip to content

fix(ctrace): rename source to index in trace metadata and CSV - #2639

Merged
thorstendb-ARM merged 6 commits into
mainfrom
fix/ctrace-source-to-index
Oct 2, 2026
Merged

thorstendb-ARM merged 6 commits into
mainfrom
fix/ctrace-source-to-index

Conversation

@thorstendb-ARM

@thorstendb-ARM thorstendb-ARM commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Fixes

Implements the source → index follow-up in Open-CMSIS-Pack/vscode-cmsis-debugger#1216.
Specification: cmsis-toolbox#713.

Changes

  • Read scalar or array index values in ctrace-refs for ITM channels and DWT comparators.
  • Ignore unconsumed YAML fields. Validate timestamp prescalers only for setups used by a processor route.
  • Rename the fourth CSV column to index, preserving its values.
  • Update documentation, fixtures and regression tests.

Checklist

  • 🤖 This change is covered by unit tests.
  • 🤹 Manual CLI testing has been performed.
  • 🛡️ Security impacts have been considered.
  • 📖 Documentation updates are complete.
  • 🧠 Third-party dependencies and TPIP require no changes.

@thorstendb-ARM
thorstendb-ARM marked this pull request as draft October 1, 2026 13:23
@thorstendb-ARM
thorstendb-ARM marked this pull request as ready for review October 1, 2026 13:26
@github-actions

github-actions Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Test Results

    6 files     12 suites   12s ⏱️
  529 tests   529 ✅  0 💤 0 ❌
1 587 runs  1 569 ✅ 18 💤 0 ❌

Results for commit 291d9c9.

♻️ This comment has been updated with latest results.

jreineckearm
jreineckearm previously approved these changes Oct 1, 2026

@jreineckearm jreineckearm left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov

codecov Bot commented Oct 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.00%. Comparing base (105d531) to head (291d9c9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2639   +/-   ##
=======================================
  Coverage   79.00%   79.00%           
=======================================
  Files         207      207           
  Lines       33279    33286    +7     
  Branches    19311    19315    +4     
=======================================
+ Hits        26291    26298    +7     
  Misses       4661     4661           
  Partials     2327     2327           
Flag Coverage Δ
ctrace-cov 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
tools/ctrace/src/output/csv/CsvRowMapper.cpp 100.00% <100.00%> (ø)
tools/ctrace/src/tracerun/CtraceRunMeta.cpp 100.00% <100.00%> (ø)
tools/ctrace/src/tracerun/TraceRunConfig.h 100.00% <100.00%> (ø)
...ls/ctrace/src/tracerun/YmlTraceRunConfigReader.cpp 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jreineckearm jreineckearm left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thorstendb-ARM
thorstendb-ARM merged commit 30f5e81 into main Oct 2, 2026
23 checks passed
@thorstendb-ARM
thorstendb-ARM deleted the fix/ctrace-source-to-index branch October 2, 2026 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants