fix(analysis): refuse malformed OPENSYSML_TOOL_ENV_PASSTHROUGH names - #613
Merged
Merged
Conversation
Co-Authored-By: jason.han <hanhuijun@gmail.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Co-Authored-By: jason.han <hanhuijun@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
renderEnvforwarded every comma-separated entry ofOPENSYSML_TOOL_ENV_PASSTHROUGHtoos.LookupEnvunchecked. An entry such asBAD=VALUEis not a variable name; it is now refused before the process is composed:Entries containing
=or a NUL byte are refused; surrounding whitespace and empty entries are still tolerated. This closes the remaining review finding from #581 on the invocation block's environment composition.How it was verified
TestInvocationEnvPassthroughRefusesMalformedNamesininternal/exec/analysis/invocation_test.go: a valid name forwards,BAD=VALUEandBAD = VALUEare refused with the exact message, empty entries are tolerated. (A NUL entry cannot be set throughos.Setenv, so that branch is covered by code only.)go build ./...,go vet ./...,gofmt -l .empty,go test -count=1 ./internal/exec/analysis/...,python3 scripts/changelog.py check.Checklist
make testandmake lintpass locallydocs/reference/environment.md)changes/unreleased/tool-env-passthrough-names.fixed.mdmake docs-countsrun if a gate count moved (none moved)Link to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/af142480eed947fc95efba5cb14c8511
Open in Devin Desktop: https://nasa-jpl-demo.devinenterprise.com/desktop/session/af142480eed947fc95efba5cb14c8511?variant=devin
Requested by: @HuiJun