Conversation
lohedges
had a problem deploying
to
sire-build
September 29, 2026 08:32 — with
GitHub Actions
Failure
martin-wat-cresset
pushed a commit
to cresset-group/sire
that referenced
this pull request
Sep 30, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gemmi 0.7 switched its Python bindings from pybind11 to nanobind, so structures can no longer be passed via the pyboost11 bridge. This PR switches to exchanging them as gemmi's own binary pickle state instead, using the vendored zpp serializer (MIT). This allows us to drop the pybind11 dependency and re-enable the Sire-Gemmi build, which had been temporarily dropped.
develinto this branch before issuing this pull request (e.g. by runninggit pull origin devel): [y]