Skip to content

Update to gemmi 0.7 and re-enable the SireGemmi converter - #494

Merged
lohedges merged 2 commits into
develfrom
fix_gemmi
Sep 29, 2026
Merged

lohedges merged 2 commits into
develfrom
fix_gemmi

Conversation

@lohedges

Copy link
Copy Markdown
Contributor

gemmi 0.7 switched its Python bindings from pybind11 to nanobind, so structures can no longer be passed via the pyboost11 bridge. This PR switches to exchanging them as gemmi's own binary pickle state instead, using the vendored zpp serializer (MIT). This allows us to drop the pybind11 dependency and re-enable the Sire-Gemmi build, which had been temporarily dropped.

  • I confirm that I have merged the latest version of devel into this branch before issuing this pull request (e.g. by running git pull origin devel): [y]
  • I confirm that I have added a changelog entry to the changelog (we will add a link to this PR as part of the review): [y]
  • I confirm that I have permission to release this code under the GPL3 license: [y]

@lohedges
lohedges merged commit fa27950 into devel Sep 29, 2026
5 checks passed
@lohedges
lohedges deleted the fix_gemmi branch September 29, 2026 11:02
martin-wat-cresset pushed a commit to cresset-group/sire that referenced this pull request Sep 30, 2026

This branch was successfully deployed

1 active deployment
sire-build — 1b332b3e Deployed Sep 29, 2026 by lohedges via build (3.12, windows) #447
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant