Skip to content

Fix issue #496 - #497

Merged
lohedges merged 2 commits into
develfrom
fix_496
Sep 29, 2026
Merged

lohedges merged 2 commits into
develfrom
fix_496

Conversation

@lohedges

Copy link
Copy Markdown
Contributor

This PR closes #496 by recomputing required box attributes when loading a stream file and assigning them on copy.

  • I confirm that I have merged the latest version of devel into this branch before issuing this pull request (e.g. by running git pull origin devel): [y]
  • I confirm that I have added a changelog entry to the changelog (we will add a link to this PR as part of the review): [y]
  • I confirm that I have permission to release this code under the GPL3 license: [y]

@lohedges lohedges added bug Something isn't working cresset related to work with cresset labels Sep 29, 2026
@lohedges
lohedges merged commit 3e458d5 into devel Sep 29, 2026
@lohedges
lohedges deleted the fix_496 branch September 29, 2026 21:05
martin-wat-cresset pushed a commit to cresset-group/sire that referenced this pull request Sep 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working cresset related to work with cresset

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] TriclinicBox loses its metric matrix when streamed or assigned, giving wrong minimum-image distances

1 participant