Skip to content

webui: fix line break in the English access point update button label - #81

Merged
jens-maus merged 1 commit into
mainfrom
jens-maus/migrate-0128-webui-access-point-button-label
Sep 29, 2026
Merged

jens-maus merged 1 commit into
mainfrom
jens-maus/migrate-0128-webui-access-point-button-label

Conversation

@jens-maus

@jens-maus jens-maus commented Sep 29, 2026 •

Copy link
Copy Markdown
Member

Original OpenCCU rootfs patch: 0128
Original filename: 0128-WebUI-Fix-UpdateAccessPointButton.patch
Original patch: ''https://github.com/OpenCCU/OpenCCU/blob/f795bc0418e10ca244cbe8ca7893e835d9523152/buildroot-external/package/openccu-base/rootfs-patches/0128-WebUI-Fix-UpdateAccessPointButton.patch''

The English label of the button for updating Homematic IP access points with incompatible firmware (btnAccessPoints in src/webui/www/webui/js/lang/en/translate.lang.extension.js) broke the line after "with". This split the phrase "with incompatible FW" across both lines. This moves the line break before "with", so the label reads "Update Access Points" on the first line and "with incompatible FW" on the second. The German label is unchanged.

OpenCCU rootfs patches 0001, 0007, 0044 and 0099 also modify this file and precede 0128 in the series. None of their hunks covers this line, and the line count is unchanged, so they all still apply unchanged.

Validation

  • OpenCCU scripts/base-patch-migration.py validate with the canonical Buildroot 2026.08 git4 archive of this branch (5c691705, sha256 ef08fbb8d017004e8fcbcad13874ed84cefde620e5c6be967af6e217c395c4f4) and --skip-patch 0128: PASS (the other 122 rootfs patches apply with zero fuzz).
  • compare against the current pin baseline (2aee789d, all 123 patches): IDENTICAL (4668 entries).

OpenCCU cleanup PR (patch removal, pin and archive hash update): OpenCCU/OpenCCU#4275

Summary by CodeRabbit

  • Style
    • Updated the access points label so “with incompatible FW” appears on the second line.

The English label of the button for updating Homematic IP access
points with incompatible firmware broke the line after "with", which
split the phrase "with incompatible FW" across both lines. Move the
line break before "with" so the label reads "Update Access Points"
on the first and "with incompatible FW" on the second line.

This natively replaces OpenCCU rootfs patch
0128-WebUI-Fix-UpdateAccessPointButton.patch.
@coderabbitai

coderabbitai Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: f5852322-2ffe-40ab-8c1d-81cc6ff26e8b

📥 Commits

Reviewing files that changed from the base of the PR and between 2aee789 and 5c69170.

📒 Files selected for processing (1)
  • src/webui/www/webui/js/lang/en/translate.lang.extension.js

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The English btnAccessPoints label now places “with incompatible FW” on the second line.

Changes

Access point label wrapping

Layer / File(s) Summary
Update English label line break
src/webui/www/webui/js/lang/en/translate.lang.extension.js
The btnAccessPoints label now places “with incompatible FW” on the second line.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 5c691

The change only adjusts the English label’s wrapping, with no identified user-facing or operational issue. It is ready to merge.

Architecture Summary

Architecture risk: 🔵 Low · up to 5c691

The change affects 1 system.

Changed systems: src

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — src (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in src/webui/www/webui/js/lang/en/translate.lang.extension.js: Changed the btnAccessPoints label’s line break: “with” now appears with “incompatible FW” on the second line.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: fixing the English access point update button line break.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jens-maus
jens-maus merged commit a7c8217 into main Sep 29, 2026
5 checks passed
@jens-maus
jens-maus deleted the jens-maus/migrate-0128-webui-access-point-button-label branch September 29, 2026 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant