Skip to content

webui: keep the selected sort header cell as tall as the others - #82

Merged
jens-maus merged 1 commit into
mainfrom
jens-maus/migrate-0116-webui-sort-header-cell-box-sizing
Sep 30, 2026
Merged

jens-maus merged 1 commit into
mainfrom
jens-maus/migrate-0116-webui-sort-header-cell-box-sizing

Conversation

@jens-maus

@jens-maus jens-maus commented Sep 30, 2026 •

Copy link
Copy Markdown
Member

Original OpenCCU rootfs patch: 0116
Original filename: 0116-WebUI-Chrome-88-Sort-Header-Cell.patch
Original patch: ''https://github.com/OpenCCU/OpenCCU/blob/dec0513f896e3e0618c450fe8a53b590047c071d/buildroot-external/package/openccu-base/rootfs-patches/0116-WebUI-Chrome-88-Sort-Header-Cell.patch''
Original issue: OpenCCU/OpenCCU#1152

The table header cell of the currently sorted column (.tHeaderCellSortSelected) combines height: 100% with padding and a border. Under the default content-box sizing, Chrome added both to the full cell height, so the selected header cell rendered taller than the other header cells, for example in the program list ("Programme und Zentralenverknüpfungen"). Firefox and Safari were not affected. This adds box-sizing: border-box to the rule, so padding and border are included in the height.

The change is made in src/webui/www_source/ise/style/style.css, the source from which create_style_css.tcl generates the installed www/webui/style.css. The file's ISO-8859-1 encoding and CRLF line endings are preserved. The root www/webui/style.css is an unused legacy copy and is left unchanged.

Twelve earlier OpenCCU rootfs patches (0029 to 0114) also modify the generated www/webui/style.css. None of their hunks covers this rule, so they all still apply unchanged.

Validation

  • OpenCCU scripts/base-patch-migration.py validate with the canonical Buildroot 2026.08 git4 archive of this branch (f221fc5e, sha256 a48a0be30a49197eee5dfb7ab04c4da1ee5f9148ff432c561c02050e057e75d2) and --skip-patch 0116: PASS (the other 121 rootfs patches apply with zero fuzz).
  • compare against the current pin baseline (a7c8217c, all 122 patches): IDENTICAL (4668 entries).

OpenCCU cleanup PR (patch removal, pin and archive hash update): OpenCCU/OpenCCU#4277

Summary by CodeRabbit

  • Style
    • Improved sizing consistency for selected table header cells.

The table header cell of the currently sorted column
(.tHeaderCellSortSelected) combines "height: 100%" with padding and a
border. Under the default content-box sizing, Chrome adds both to the
full cell height, so the selected header cell rendered taller than the
other header cells, e.g. in the program list. Use border-box sizing so
padding and border are included in the height.

This natively replaces OpenCCU rootfs patch
0116-WebUI-Chrome-88-Sort-Header-Cell.patch.
@coderabbitai

coderabbitai Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 94a7a874-72ae-4d30-909e-ee175e1757ff

📥 Commits

Reviewing files that changed from the base of the PR and between a7c8217 and f221fc5.

📒 Files selected for processing (1)
  • src/webui/www_source/ise/style/style.css

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The .tHeaderCellSortSelected CSS rule now sets box-sizing to border-box.

Changes

Selected header cell style

Layer / File(s) Summary
Selected header cell sizing
src/webui/www_source/ise/style/style.css
The .tHeaderCellSortSelected rule adds box-sizing: border-box.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to f221f

The change reaches the targeted selected headers, with no concrete merge-blocking risk identified.

Architecture Summary

Architecture risk: 🔵 Low · up to f221f

The change affects 1 system.

Changed systems: src

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — src (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in src/webui/www_source/ise/style/style.css: Added box-sizing: border-box to .tHeaderCellSortSelected.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: keeping the selected sort header cell the same height as other header cells.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jens-maus
jens-maus merged commit f484a5b into main Sep 30, 2026
5 checks passed
@jens-maus
jens-maus deleted the jens-maus/migrate-0116-webui-sort-header-cell-box-sizing branch September 30, 2026 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant