Repository navigation
webui: keep the selected sort header cell as tall as the others - #82
Conversation
The table header cell of the currently sorted column (.tHeaderCellSortSelected) combines "height: 100%" with padding and a border. Under the default content-box sizing, Chrome adds both to the full cell height, so the selected header cell rendered taller than the other header cells, e.g. in the program list. Use border-box sizing so padding and border are included in the height. This natively replaces OpenCCU rootfs patch 0116-WebUI-Chrome-88-Sort-Header-Cell.patch.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe ChangesSelected header cell style
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The change reaches the targeted selected headers, with no concrete merge-blocking risk identified. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Original OpenCCU rootfs patch: 0116
Original filename:
0116-WebUI-Chrome-88-Sort-Header-Cell.patchOriginal patch:
''https://github.com/OpenCCU/OpenCCU/blob/dec0513f896e3e0618c450fe8a53b590047c071d/buildroot-external/package/openccu-base/rootfs-patches/0116-WebUI-Chrome-88-Sort-Header-Cell.patch''Original issue: OpenCCU/OpenCCU#1152
The table header cell of the currently sorted column (
.tHeaderCellSortSelected) combinesheight: 100%with padding and a border. Under the default content-box sizing, Chrome added both to the full cell height, so the selected header cell rendered taller than the other header cells, for example in the program list ("Programme und Zentralenverknüpfungen"). Firefox and Safari were not affected. This addsbox-sizing: border-boxto the rule, so padding and border are included in the height.The change is made in
src/webui/www_source/ise/style/style.css, the source from whichcreate_style_css.tclgenerates the installedwww/webui/style.css. The file's ISO-8859-1 encoding and CRLF line endings are preserved. The rootwww/webui/style.cssis an unused legacy copy and is left unchanged.Twelve earlier OpenCCU rootfs patches (0029 to 0114) also modify the generated
www/webui/style.css. None of their hunks covers this rule, so they all still apply unchanged.Validation
scripts/base-patch-migration.py validatewith the canonical Buildroot 2026.08git4archive of this branch (f221fc5e, sha256a48a0be30a49197eee5dfb7ab04c4da1ee5f9148ff432c561c02050e057e75d2) and--skip-patch 0116: PASS (the other 121 rootfs patches apply with zero fuzz).compareagainst the current pin baseline (a7c8217c, all 122 patches): IDENTICAL (4668 entries).OpenCCU cleanup PR (patch removal, pin and archive hash update): OpenCCU/OpenCCU#4277
Summary by CodeRabbit