Skip to content

webui: sort the device list of the LAN gateway configuration by name - #87

Merged
jens-maus merged 1 commit into
mainfrom
jens-maus/migrate-0115-webui-gateway-device-list-sort
Sep 30, 2026
Merged

jens-maus merged 1 commit into
mainfrom
jens-maus/migrate-0115-webui-gateway-device-list-sort

Conversation

@jens-maus

@jens-maus jens-maus commented Sep 30, 2026 •

Copy link
Copy Markdown
Member

Original OpenCCU rootfs patch: 0115
Original filename: 0115-WebUI-GatewayConfiguration-DevicesListSortByName.patch
Original patch: ''https://github.com/OpenCCU/OpenCCU/blob/52add2185e445c301c6339db3adfa873bf2c4a23/buildroot-external/package/openccu-base/rootfs-patches/0115-WebUI-GatewayConfiguration-DevicesListSortByName.patch''
Original PR: OpenCCU/OpenCCU#1147

The device list in "Einstellungen" > "Systemsteuerung" > "LAN Gateway Konfiguration" (loadDevices() in src/webui/www_source/webui/js/pages/systemconfig/bidcosrfpage.js) was shown in the unsorted order of the device model. This change sorts the BidCos-RF devices by name with the existing Array.prototype.ex_sortBy() helper. DeviceList.listDevices() returns a new array (Object.values(...)), so sorting it in place does not change the global device list.

The file's ISO-8859-1 encoding and CRLF line endings are preserved. It is part of the generated www/webui/webui.js.

36 earlier OpenCCU rootfs patches (0001 to 0114) also modify the generated www/webui/webui.js. None of their hunks covers this line, and the line count is unchanged, so they all still apply unchanged.

Validation

  • OpenCCU scripts/base-patch-migration.py validate with the canonical Buildroot 2026.08 git4 archive of this branch (d86d8d3a, sha256 e01398661f4a08c1ceeb690495c717b51ee8e31a99e5c5310cfcf58ac2209906) and --skip-patch 0115: PASS (the other 116 rootfs patches apply with zero fuzz).
  • compare against the current pin baseline (afa0cd9b, all 117 patches): IDENTICAL (4668 entries).

OpenCCU cleanup PR (patch removal, pin and archive hash update): OpenCCU/OpenCCU#4288

The device list in "Einstellungen" > "Systemsteuerung" > "LAN Gateway
Konfiguration" was shown in the unsorted order of the device model.
Sort the BidCos-RF devices by name. DeviceList.listDevices() returns a
new array, so sorting it does not change the global device list.

This natively replaces OpenCCU rootfs patch
0115-WebUI-GatewayConfiguration-DevicesListSortByName.patch.
@coderabbitai

coderabbitai Bot commented Sep 30, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 10 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 79c454f6-3e30-40ad-b828-4eb586f95ac0

📥 Commits

Reviewing files that changed from the base of the PR and between afa0cd9 and d86d8d3.

📒 Files selected for processing (1)
  • src/webui/www_source/webui/js/pages/systemconfig/bidcosrfpage.js
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jens-maus
jens-maus merged commit ed7f7c1 into main Sep 30, 2026
5 checks passed
@jens-maus
jens-maus deleted the jens-maus/migrate-0115-webui-gateway-device-list-sort branch September 30, 2026 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant