webui: sort the device list of the LAN gateway configuration by name - #87
Merged
jens-maus merged 1 commit intoSep 30, 2026
Merged
Conversation
The device list in "Einstellungen" > "Systemsteuerung" > "LAN Gateway Konfiguration" was shown in the unsorted order of the device model. Sort the BidCos-RF devices by name. DeviceList.listDevices() returns a new array, so sorting it does not change the global device list. This natively replaces OpenCCU rootfs patch 0115-WebUI-GatewayConfiguration-DevicesListSortByName.patch.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 10 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jens-maus
deleted the
jens-maus/migrate-0115-webui-gateway-device-list-sort
branch
September 30, 2026 17:21
This was referenced Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original OpenCCU rootfs patch: 0115
Original filename:
0115-WebUI-GatewayConfiguration-DevicesListSortByName.patchOriginal patch:
''https://github.com/OpenCCU/OpenCCU/blob/52add2185e445c301c6339db3adfa873bf2c4a23/buildroot-external/package/openccu-base/rootfs-patches/0115-WebUI-GatewayConfiguration-DevicesListSortByName.patch''Original PR: OpenCCU/OpenCCU#1147
The device list in "Einstellungen" > "Systemsteuerung" > "LAN Gateway Konfiguration" (
loadDevices()insrc/webui/www_source/webui/js/pages/systemconfig/bidcosrfpage.js) was shown in the unsorted order of the device model. This change sorts the BidCos-RF devices by name with the existingArray.prototype.ex_sortBy()helper.DeviceList.listDevices()returns a new array (Object.values(...)), so sorting it in place does not change the global device list.The file's ISO-8859-1 encoding and CRLF line endings are preserved. It is part of the generated
www/webui/webui.js.36 earlier OpenCCU rootfs patches (0001 to 0114) also modify the generated
www/webui/webui.js. None of their hunks covers this line, and the line count is unchanged, so they all still apply unchanged.Validation
scripts/base-patch-migration.py validatewith the canonical Buildroot 2026.08git4archive of this branch (d86d8d3a, sha256e01398661f4a08c1ceeb690495c717b51ee8e31a99e5c5310cfcf58ac2209906) and--skip-patch 0115: PASS (the other 116 rootfs patches apply with zero fuzz).compareagainst the current pin baseline (afa0cd9b, all 117 patches): IDENTICAL (4668 entries).OpenCCU cleanup PR (patch removal, pin and archive hash update): OpenCCU/OpenCCU#4288