Repository navigation
webui: add CUxD and CCU-Jack to the device list interface filter - #88
Conversation
The interface filter of the device list ("Einstellungen" > "Geräte")
only offered BidCos-RF, BidCos-Wired, HmIP-RF, virtual devices and
System, so devices of the CUxD and CCU-Jack interfaces could not be
filtered by their interface. Add both entries. ListFilter.matchString()
compares the entry name with the device's interface name, so no further
logic is needed.
This natively replaces OpenCCU rootfs patch
0041-WebUI-ThirdPartyDevice-Sorting.patch.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe Central device-list interface filter now includes CUxD and CCU-Jack. ChangesDevice-list interface filter
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Feature Merge Risk: ⚪ Minimal · up to No actionable filter regression is established by the available source evidence, so no merge blocker remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Original OpenCCU rootfs patch: 0041
Original filename:
0041-WebUI-ThirdPartyDevice-Sorting.patchOriginal patch:
''https://github.com/OpenCCU/OpenCCU/blob/66a4635edd6e0dd26431611bf8192cfadc7097db/buildroot-external/package/openccu-base/rootfs-patches/0041-WebUI-ThirdPartyDevice-Sorting.patch''Related issue: OpenCCU/OpenCCU#2445 (CCU-Jack entry added in OpenCCU/OpenCCU#2446)
The interface filter of the device list ("Einstellungen" > "Geräte",
INTERFACESinsrc/webui/www_source/webui/js/pages/systemconfig/devicelistpage.js) only offered BidCos-RF, BidCos-Wired, HmIP-RF, virtual devices and System. As a result, devices of the CUxD and CCU-Jack interfaces could not be filtered by their interface. This change adds both entries.ListFilter.matchString()compares the entry name withdevice.interfaceName, so the namesCUxDandCCU-Jackare all that is needed.The file's ISO-8859-1 encoding and CRLF line endings are preserved. It is part of the generated
www/webui/webui.js.Seven earlier OpenCCU rootfs patches (0001, 0026, 0029, 0031, 0032, 0038 and 0039) also modify the generated
www/webui/webui.js. None of their hunks covers these lines. Their hunks after this position are shifted by two lines, whichpatchhandles as an offset without fuzz.Validation
scripts/base-patch-migration.py validatewith the canonical Buildroot 2026.08git4archive of this branch (ddbb4072, sha256bd9b1052fef351fe9cd7a26d09ca1c2a95098dfad4fb6d9055a9d92dc35713bd) and--skip-patch 0041: PASS (the other 115 rootfs patches apply with zero fuzz).compareagainst the current pin baseline (ed7f7c1b, all 116 patches): IDENTICAL (4668 entries).OpenCCU cleanup PR (patch removal, pin and archive hash update): OpenCCU/OpenCCU#4290
Summary by CodeRabbit