Skip to content

webui: add CUxD and CCU-Jack to the device list interface filter - #88

Merged
jens-maus merged 1 commit into
mainfrom
jens-maus/migrate-0041-webui-cuxd-ccujack-interface-filter
Sep 30, 2026
Merged

jens-maus merged 1 commit into
mainfrom
jens-maus/migrate-0041-webui-cuxd-ccujack-interface-filter

Conversation

@jens-maus

@jens-maus jens-maus commented Sep 30, 2026 •

Copy link
Copy Markdown
Member

Original OpenCCU rootfs patch: 0041
Original filename: 0041-WebUI-ThirdPartyDevice-Sorting.patch
Original patch: ''https://github.com/OpenCCU/OpenCCU/blob/66a4635edd6e0dd26431611bf8192cfadc7097db/buildroot-external/package/openccu-base/rootfs-patches/0041-WebUI-ThirdPartyDevice-Sorting.patch''
Related issue: OpenCCU/OpenCCU#2445 (CCU-Jack entry added in OpenCCU/OpenCCU#2446)

The interface filter of the device list ("Einstellungen" > "Geräte", INTERFACES in src/webui/www_source/webui/js/pages/systemconfig/devicelistpage.js) only offered BidCos-RF, BidCos-Wired, HmIP-RF, virtual devices and System. As a result, devices of the CUxD and CCU-Jack interfaces could not be filtered by their interface. This change adds both entries. ListFilter.matchString() compares the entry name with device.interfaceName, so the names CUxD and CCU-Jack are all that is needed.

The file's ISO-8859-1 encoding and CRLF line endings are preserved. It is part of the generated www/webui/webui.js.

Seven earlier OpenCCU rootfs patches (0001, 0026, 0029, 0031, 0032, 0038 and 0039) also modify the generated www/webui/webui.js. None of their hunks covers these lines. Their hunks after this position are shifted by two lines, which patch handles as an offset without fuzz.

Validation

  • OpenCCU scripts/base-patch-migration.py validate with the canonical Buildroot 2026.08 git4 archive of this branch (ddbb4072, sha256 bd9b1052fef351fe9cd7a26d09ca1c2a95098dfad4fb6d9055a9d92dc35713bd) and --skip-patch 0041: PASS (the other 115 rootfs patches apply with zero fuzz).
  • compare against the current pin baseline (ed7f7c1b, all 116 patches): IDENTICAL (4668 entries).

OpenCCU cleanup PR (patch removal, pin and archive hash update): OpenCCU/OpenCCU#4290

Summary by CodeRabbit

  • New Features
    • Added CUxD and CCU-Jack to the device-list interface options.

The interface filter of the device list ("Einstellungen" > "Geräte")
only offered BidCos-RF, BidCos-Wired, HmIP-RF, virtual devices and
System, so devices of the CUxD and CCU-Jack interfaces could not be
filtered by their interface. Add both entries. ListFilter.matchString()
compares the entry name with the device's interface name, so no further
logic is needed.

This natively replaces OpenCCU rootfs patch
0041-WebUI-ThirdPartyDevice-Sorting.patch.
@coderabbitai

coderabbitai Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 86f475c3-b9d5-464f-943c-661874884531

📥 Commits

Reviewing files that changed from the base of the PR and between ed7f7c1 and ddbb407.

📒 Files selected for processing (1)
  • src/webui/www_source/webui/js/pages/systemconfig/devicelistpage.js

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The Central device-list interface filter now includes CUxD and CCU-Jack.

Changes

Device-list interface filter

Layer / File(s) Summary
Add interface options
src/webui/www_source/webui/js/pages/systemconfig/devicelistpage.js
The Central device-list interface filter adds CUxD and CCU-Jack options.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to ddbb4

No actionable filter regression is established by the available source evidence, so no merge blocker remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding CUxD and CCU-Jack to the device list interface filter.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jens-maus
jens-maus merged commit c0909d8 into main Sep 30, 2026
5 checks passed
@jens-maus
jens-maus deleted the jens-maus/migrate-0041-webui-cuxd-ccujack-interface-filter branch September 30, 2026 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant