webui: wrap long values in the user system variable table - #89
Merged
jens-maus merged 1 commit intoSep 30, 2026
Merged
Conversation
The system variable table of the user configuration ("Einstellungen" >
"Benutzerverwaltung" > user > "Systemvariablen") uses the automatic
table layout, so long names, descriptions or values without spaces
widened the table beyond the dialog and caused a horizontal scrollbar.
Use a fixed table layout and let long words break, so the columns keep
the widths defined in the colgroup.
This natively replaces OpenCCU rootfs patch
0094-WebUI-userSysVarTblValuesWordWrap.patch.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 24 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jens-maus
deleted the
jens-maus/migrate-0094-webui-user-sysvar-table-word-wrap
branch
September 30, 2026 20:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original OpenCCU rootfs patch: 0094
Original filename:
0094-WebUI-userSysVarTblValuesWordWrap.patchOriginal patch:
https://github.com/OpenCCU/OpenCCU/blob/e183b6f2c08698fdb800ba59da73030cf2bab3b4/buildroot-external/package/openccu-base/rootfs-patches/0094-WebUI-userSysVarTblValuesWordWrap.patchOriginal PR: OpenCCU/OpenCCU#991
The system variable table of the user configuration ("Einstellungen" > "Benutzerverwaltung" > user > "Systemvariablen", built by
BuildUserSvTable()insystem.fn) uses the table class.CLASS02105with the automatic table layout. Long names, descriptions or values without spaces therefore widened the table beyond the dialog and caused a horizontal scrollbar. This addstable-layout: fixedandword-wrap: break-wordto the rule, so the columns keep the widths defined in the table'scolgroupand long words break instead..CLASS02105is used only by this table.The change is made in
src/webui/www_source/webui/css/x_style.css, whichcreate_style_css.tclconcatenates into the installedwww/webui/style.css. The file's CRLF line endings are preserved. The rootwww/webui/style.cssis an unused legacy copy and is left unchanged.Eight earlier OpenCCU rootfs patches (0029 to 0090) also modify the generated
www/webui/style.css. None of their hunks covers this rule, so they all still apply unchanged. The later patches already contain the two lines in their workspaces.Validation
scripts/base-patch-migration.py validatewith the canonical Buildroot 2026.08git4archive of this branch (f9d57a8c, sha2565712c8a59eb2ea81fcd8309daded32954966828baff7d376be3fd300f09a63b7) and--skip-patch 0094: PASS (the other 114 rootfs patches apply with zero fuzz).compareagainst the current pin baseline (c0909d88, all 115 patches): IDENTICAL (4668 entries).OpenCCU cleanup PR (patch removal, pin and archive hash update): OpenCCU/OpenCCU#4291