Conversation
The script editor for program script actions sends the script to ReGa inside a super string (^...^), both for the syntax check in editScript.htm and when saving the action via iseSingleDestination.SetScript(). A ^ character in the script ended that super string early, so the syntax check failed and a script containing ^ could not be saved. Replace each ^ with ^#'^'#^ before embedding the script. This closes the super string, concatenates a single-quoted '^' and opens a new super string, so ReGa receives the original script unchanged. This natively replaces OpenCCU rootfs patch 0076-WebUI-Fix-SuperCharScriptUse.patch.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 44 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original OpenCCU rootfs patch: 0076
Original filename:
0076-WebUI-Fix-SuperCharScriptUse.patchOriginal patch:
https://github.com/OpenCCU/OpenCCU/blob/e49a57c5be83eb7b17d747266a5c08bf374e08d7/buildroot-external/package/openccu-base/rootfs-patches/0076-WebUI-Fix-SuperCharScriptUse.patchOriginal issue: OpenCCU/OpenCCU#225
The script editor for program script actions sends the script to ReGa inside a super string (
^...^). It does this in two places: for the syntax check ineditScript.htm, and when the action is saved viaiseSingleDestination.SetScript(). A^character in the script ended that super string early, so the syntax check failed and a script containing^could not be saved.Both places now replace each
^with^#'^'#^before embedding the script. This closes the super string, concatenates a single-quoted'^'and opens a new super string, so ReGa receives the original script unchanged.Changed files:
src/webui/rega/www/pages/msg/editScript.htm(CRLF line endings preserved)src/webui/www_source/ise/js/iseFunctions.js, which is part of the generatedwww/webui/webui.js(ISO-8859-1 encoding and LF line endings preserved)The root
www/copies are unused legacy copies and are left unchanged.Earlier OpenCCU rootfs patches also modify these files:
editScript.htm: patch 0046. Its hunks do not cover the changed line; patch 0046 adds its own, already escaped copy of the line.webui.js: 21 patches (0001 to 0075). None of their hunks covers the changed line.The later
webui.jsworkspaces already contain the change, except the workspace of 0125. That workspace has been out of step with the chain since OpenCCU #4129; patch 0125 still applies with zero fuzz.Validation
scripts/base-patch-migration.py validatewith the canonical Buildroot 2026.08git4archive of this branch (fc051519, sha256644ef87590ce56c905472f69e7fb4728ad76a29f9ba19c9a4affeece6f793a1d) and--skip-patch 0076: PASS (the other 112 rootfs patches apply with zero fuzz).compareagainst the current pin baseline (4a428491, all 113 patches): IDENTICAL (4668 entries).OpenCCU cleanup PR (patch removal, pin and archive hash update) will follow after this PR is merged.