Repository navigation
Conversation
r0ssing
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & Why
Signing sideways still changed the page after #1032. That PR stops propagation inside the canvas's React touch handlers, but the page swipe comes from
react-swipeable, which listens with native listeners on the form's scroll area. React dispatches from the root, after that native listener has run, so the swipe still fired and the unfinished signature was lost.This change makes
SwipeLayoutRendererignore swipes whose touch started on acanvas(the signature pad) or on any element markeddata-no-swipe. Touch events keep the element where the finger went down as their target, so the check holds on Android WebView and iOS WKWebView. Swiping anywhere else on the page navigates as before.The new
SwipeLayoutRenderer.test.tsxrenders the real swipe layout with a signature question and sends touch swipes. The canvas test fails on currentdevand passes with this change; a second test confirms normal page swipes still work.Type of Change
Component(s) Changed
Testing
Checklist
Closes #123Closes #1037