Skip to content

Adopt public fields for UCSI types #974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
RobertZ2011 wants to merge 1 commit into
base: main
Choose a base branch
from
+282 −209
Draft

Adopt public fields for UCSI types #974

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 26 additions & 17 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

90 changes: 58 additions & 32 deletions examples/std/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 5 additions & 2 deletions examples/std/src/lib/type_c/mock_controller.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,9 +320,12 @@ impl tcpm_interface::controller::type_c::StateMachine for Controller<'_> {

impl tcpm_interface::ucsi::Lpm for Controller<'_> {
async fn execute_lpm_command(&mut self, command: lpm::LocalCommand) -> Result<Option<lpm::ResponseData>, PdError> {
debug!("Execute UCSI command for port {:?}: {command:?}", command.port());
debug!(
"Execute UCSI command for port {:?}: {command:?}",
command.connector_number()
);
match command.operation() {
lpm::CommandData::GetConnectorStatus => Ok(Some(lpm::ResponseData::GetConnectorStatus(
lpm::CommandData::GetConnectorStatus(_) => Ok(Some(lpm::ResponseData::GetConnectorStatus(
lpm::get_connector_status::ResponseData::default(),
))),
_ => Err(PdError::UnrecognizedCommand),
Expand Down
Loading
Loading